Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strings_ja.txt #46

Merged
merged 6 commits into from
Mar 26, 2022
Merged

Update strings_ja.txt #46

merged 6 commits into from
Mar 26, 2022

Conversation

maboroshin
Copy link
Contributor

Hello developer!

You will need to update the readme.html. I updated the Japanese translation in 2018. Then, I have read the readme.html and sent it to your Gmail. However, if you have not read the email and it is updated on Github. If so, revising readme.html is a good idea.

@sylikc
Copy link
Owner

sylikc commented Mar 14, 2022

Hi @maboroshin thanks for the translation! I'll merge it into the next release.

I'm not the original author, but continuing his work. Please send your email or post it up somewhere and I'll merge the readme.html.... I know it's certainly out of date

@sylikc sylikc added the enhancement New feature or request label Mar 14, 2022
@maboroshin
Copy link
Contributor Author

maboroshin commented Mar 14, 2022

Thanks. Nice work.

In readme.html, it says to send the translation file to the developer, not Github.
https://github.com/sylikc/jpegview/blob/master/src/JPEGView/Config/readme.html#L297

@sylikc
Copy link
Owner

sylikc commented Mar 14, 2022

In readme.html, it says to send the translation file to the developer, not Github. https://github.com/sylikc/jpegview/blob/master/JPEGView/Config/readme.html#L297

Oh... ok. I got it... this might be why I got an email for translation. I have to update that... actual tbh, I haven't read through the whole readme myself haha.

@sylikc
Copy link
Owner

sylikc commented Mar 25, 2022

This is ready for merge?

@maboroshin
Copy link
Contributor Author

Please merge. My translation is complete.

@sylikc sylikc merged commit c5bc4c9 into sylikc:master Mar 26, 2022
@sylikc
Copy link
Owner

sylikc commented Mar 26, 2022

merged. Thanks for the contribution!

sylikc added a commit that referenced this pull request Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants