Two small enhancements for dealing with large folders #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll headers already fetched. This leads, at the very least, to wasted time because next time round, these headers have to be fetched again. In case of large directories, this can lead to never getting the headers of the folder at all, because with many 100'000 mails per folder, the probability of errors (mostly protocol errors) increases drastically. Make sure the fetched headers are not discarded but passed on. Signed-off-by: Attila Kinali <attila@kinali.ch>
An awful lot of time is spend on updating the status bar when downloading messages. Especially when a folder is almost completely available locally, with only a few messages that need to be fetched. In that case the update of the status bar will dominate the downloading. Updating only every 128th message reduced the download time in my set-up from 25 minutes to 3 minutes. Signed-off-by: Attila Kinali <attila@kinali.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
今日は
I have two small fixes that improve sylpheed when handling large folders.
The first ensures that fetched headers are not discarded when an error occurs.
The second speeds up downloading by not updating the UI for every message,
thus decreasing the download time considerably (I got a factor 10 in my setup).
Thanks for your consideration and have a nice day