Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cancel commands #17

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Implement cancel commands #17

merged 2 commits into from
Dec 8, 2022

Conversation

alexppxela
Copy link
Collaborator

@alexppxela alexppxela commented Nov 23, 2022

Implement these messages:

  • OrderCancelRequest (35=F)
  • OrderMassCancelRequest (35=q)

This change is Reviewable

@alexppxela alexppxela requested a review from sylr November 23, 2022 14:08
@sylr sylr force-pushed the at/cmd/cancel branch 2 times, most recently from 480f28e to e2a7ea7 Compare December 7, 2022 09:54
Copy link
Collaborator Author

@alexppxela alexppxela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 8 files at r1, 5 of 5 files at r2, 8 of 8 files at r3, 7 of 13 files at r4, 7 of 7 files at r5, 7 of 7 files at r7, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sylr)

@sylr
Copy link
Owner

sylr commented Dec 7, 2022

Could you fixup the whole branch ?

Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
@sylr sylr merged commit 9b72b25 into sylr:master Dec 8, 2022
@alexppxela alexppxela deleted the at/cmd/cancel branch December 8, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants