Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSA and generics (go1.18) #4

Closed
ldez opened this issue Mar 24, 2022 · 8 comments
Closed

SSA and generics (go1.18) #4

ldez opened this issue Mar 24, 2022 · 8 comments

Comments

@ldez
Copy link
Contributor

ldez commented Mar 24, 2022

Currently, SSA is not working with generics.

So your linter produces a panic when it is used with generics.

There is an issue open about that in the Go repository: golang/go#48525

Inside golangci-lint, we have disabled your linters: golangci/golangci-lint#2649

You have 2 solutions:

  • waiting for a version of SSA that will support generics
  • dropping the SSA analyzers and using something else to analyze the code.

Related to golang/go#50558
@ldez ldez mentioned this issue Mar 24, 2022
Closed
13 tasks
@SVilgelm
Copy link

@sylvia7788 is there any updates on this issue?

@kkHAIKE
Copy link
Owner

kkHAIKE commented May 13, 2022

I will focus on it now.. 😊

@kkHAIKE
Copy link
Owner

kkHAIKE commented Jul 13, 2022

i find another solution honnef.co/go/tools/go/ir.
it's modify from official SSA, use in staticcheck, but it's change more behavior...😭
so i think we can wait the next offical SSA. 😎

@ldez
Copy link
Contributor Author

ldez commented Jul 19, 2022

SSA has been updated and it seems to work inside golangci-lint.

@ldez ldez closed this as completed Jul 19, 2022
@ldez
Copy link
Contributor Author

ldez commented Jul 19, 2022

in fact the problem is still here

@ldez ldez reopened this Jul 19, 2022
@ldez
Copy link
Contributor Author

ldez commented Jul 19, 2022

I did some more extensive testing and the issue seems to be resolved.

@ldez ldez closed this as completed Jul 19, 2022
@ldez
Copy link
Contributor Author

ldez commented Aug 4, 2022

golangci/golangci-lint#3048

@ldez ldez reopened this Aug 4, 2022
@ldez ldez mentioned this issue Aug 16, 2022
Merged
@kkHAIKE
Copy link
Owner

kkHAIKE commented Aug 16, 2022

fixed and tested in new version

@ldez ldez closed this as completed Aug 16, 2022
@ldez ldez mentioned this issue Jan 29, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kkHAIKE @SVilgelm @ldez