Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT NestedGridField behat tests #398

Merged
merged 1 commit into from
May 28, 2024
Merged

MNT NestedGridField behat tests #398

merged 1 commit into from
May 28, 2024

Conversation

sabina-talipova
Copy link
Collaborator

@sabina-talipova sabina-talipova commented May 24, 2024 •
edited
Loading

Description

Behat tests cover the following functionality in nested gridfield:

  • Basic nested gridfield for hierarchical data, such as Group or SiteTree:
    • Gridfield Actions (edit/delete)
    • Sorting main gridfield
    • Drilling down on a specific record
    • Sort and filter the nested gridfield
  • Double nested gridfield for non-hierarchical relational data (use getNestedConfig()):
    • Gridfield Actions (edit/delete)
    • Drilling down on a specific record
    • Sort and filter the nested gridfield
  • Basic nested gridfield for non-relational data (return ArrayList):
    • Sort the nested gridfield

Parent issue

Note

This PR requires new test objects from this PR

@sabina-talipova sabina-talipova marked this pull request as ready for review May 26, 2024 20:06
@sabina-talipova sabina-talipova mentioned this pull request May 26, 2024
Closed
GuySartorelli
GuySartorelli approved these changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - rerunning CI. If that goes green, will merge.

@GuySartorelli
Copy link
Collaborator

Behat failing after being rerun a couple of times

@sabina-talipova sabina-talipova force-pushed the pulls/4/nested-gridfield-behat-tests branch from eb9aa1e to 1b175b7 Compare May 28, 2024 00:59
@sabina-talipova sabina-talipova mentioned this pull request May 28, 2024
Merged
@sabina-talipova sabina-talipova force-pushed the pulls/4/nested-gridfield-behat-tests branch from 1b175b7 to 89760c7 Compare May 28, 2024 01:51
GuySartorelli
GuySartorelli approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit edb3442 into symbiote:4 May 28, 2024
11 of 12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4/nested-gridfield-behat-tests branch May 28, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli