Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Standardise modules #83

Merged
merged 1 commit into from
Aug 2, 2022
Merged

MNT Standardise modules #83

merged 1 commit into from
Aug 2, 2022

Conversation

emteknetnz
Copy link
Collaborator

GuySartorelli
GuySartorelli requested changes Aug 1, 2022
View reviewed changes
Copy link
Collaborator

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a .scrutinizer.yml file here.

@emteknetnz
Copy link
Collaborator Author

emteknetnz commented Aug 1, 2022 •
edited
Loading

I spelt it wrong in my script :/ .scrutinzer.yml - missing an i

@emteknetnz emteknetnz force-pushed the pulls/5.2/standardise-modules branch from dc8f27f to 5a76cd2 Compare August 1, 2022 04:22
@emteknetnz
Copy link
Collaborator Author

Fixed

GuySartorelli
GuySartorelli requested changes Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update workflows to not use startsWith syntax

@emteknetnz emteknetnz force-pushed the pulls/5.2/standardise-modules branch from 5a76cd2 to 89a64f4 Compare August 2, 2022 05:38
@emteknetnz
Copy link
Collaborator Author

Updated

GuySartorelli
GuySartorelli requested changes Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keepalive also needs the startsWith syntax updated.

@emteknetnz
Copy link
Collaborator Author

Updated

@emteknetnz emteknetnz force-pushed the pulls/5.2/standardise-modules branch from 89a64f4 to b28e2e7 Compare August 2, 2022 23:15
GuySartorelli
GuySartorelli approved these changes Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MOG

@GuySartorelli GuySartorelli merged commit 4ca0f69 into symbiote:5.2 Aug 2, 2022
@GuySartorelli GuySartorelli deleted the pulls/5.2/standardise-modules branch August 2, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli