Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix saving of CheckboxSetMultivalueField #87

Merged
merged 1 commit into from
May 21, 2023
Merged

Fix saving of CheckboxSetMultivalueField #87

merged 1 commit into from
May 21, 2023

Conversation

xini
Copy link
Contributor

@xini xini commented Jan 16, 2023 •
edited by GuySartorelli
Loading

@xini xini force-pushed the fix-checkbox-saving-73 branch 2 times, most recently from 3bd2e5b to d4b9a1b Compare April 12, 2023 00:57
@xini xini mentioned this pull request Apr 12, 2023
Closed
@xini xini force-pushed the fix-checkbox-saving-73 branch 2 times, most recently from 331cfc9 to efb43bc Compare April 12, 2023 04:02
@kevingroeger
Copy link

Seems good to me!

@xini
Copy link
Contributor Author

xini commented May 18, 2023

can this be merged and tagged please?

michalkleiner
michalkleiner approved these changes May 21, 2023
View reviewed changes
Copy link
Collaborator

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works as expected.

@michalkleiner michalkleiner changed the title fix saving of CheckboxSetMultivalueField, fixes #73 Fix saving of CheckboxSetMultivalueField May 21, 2023
@michalkleiner michalkleiner changed the title Fix saving of CheckboxSetMultivalueField Fix saving of CheckboxSetMultivalueField May 21, 2023
@michalkleiner michalkleiner changed the base branch from 5 to 5.4 May 21, 2023 22:56
@michalkleiner michalkleiner merged commit d1032f3 into symbiote:5.4 May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli left review comments

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xini @kevingroeger @michalkleiner @GuySartorelli