Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem activating delegated harvesting where all keys aren't linked. #1476

Closed
jabo38 opened this issue May 1, 2021 · 8 comments · Fixed by #1594
Closed

Problem activating delegated harvesting where all keys aren't linked. #1476

jabo38 opened this issue May 1, 2021 · 8 comments · Fixed by #1594
Assignees
Labels
harvesting Issue related with harvesting P3 Issue Minor defect in aesthetics

Comments

@jabo38
Copy link

jabo38 commented May 1, 2021

Steps to reproduce.

  1. I fund an account.
  2. Age in funds for a day that are over 10,000 but under 50m.
  3. I go to harvesting to link keys and initiate transaction
  4. Play around with wallet and start harvesting on another account
  5. Come back to the first account and see the following message

image

The first problem is that harvesting was activated on this device (using a Ledger just a few minutes ago).

The second problem is that seemingly not all the keys are linked?

image

Not sure if that is part of the problem or not, but after manually entering in the node I used last time into the node box, I'm then given the only option to unlink my keys and then to later relink them.

image

Unlinking and relinking works.

@AdriaCarrera AdriaCarrera added the P3 Issue Minor defect in aesthetics label May 4, 2021
@bassemmagdy bassemmagdy self-assigned this May 5, 2021
@bassemmagdy
Copy link
Contributor

@jabo38 would you provide proper steps to reproduce?

@jabo38
Copy link
Author

jabo38 commented May 5, 2021

I did pretty much write the steps to reproduce.

@bassemmagdy
Copy link
Contributor

@jabo38 Did you activate your harvesting on a different account or is it the same account in a different profile?

@jabo38
Copy link
Author

jabo38 commented May 6, 2021

All the screen shots are for the same account in the same profile on the same computer and same desktop app.

@cryptoBeliever cryptoBeliever added the harvesting Issue related with harvesting label Jun 5, 2021
@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Jul 9, 2021

I can reproduce problem with saving keys in this way:

  • go to harvesting page (for account that have > 10000 XYM and importance > 0)
  • click "Link keys" (transaction will be sent)
  • do some interruption, like: change node. After transaction will be confirmed you will end up with not saved private keys.

@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Jul 28, 2021

@AnthonyLaw not sure if it should be seperate issue or belongs to this one. But it's very similar (this time wrong node is selected instead missing keys). If it should be reported as seperated one please let me know.

Steps:

  1. Create empty profile
  2. Import account with balance for which we will start harvesting.
  3. Go to harvesting page (by default will be selected current node - X)
  4. Switch harvesting node to Y
  5. Start harvesting, before transaction will be confirmed switch to other profile and switch current node to Z
  6. Wait for harvesting transaction confirmation
  7. After confirmation done switch to harvesting view and selected node will be current node (Z) instead correct node (Y)

Expected result:
Harvesting node should be node Y

Video: https://share.getcloudapp.com/P8u9nAqv

Original issue is fixed (keys stays).

@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Aug 3, 2021

After latest fix seems all works now 👍

  • harvesting for single account - starting - OK
  • harvesting for single account - change harvested node - OK
  • harvesting for multisig account - starting - OK
  • harvesting for multisig account - change harvested node - OK
  • choosing node for account that already harvesting (in other wallet) - OK
  • choosing node for account that already harvesting on node (node operator account) - OK

@cryptoBeliever
Copy link
Contributor

Checked in dev. Works fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
harvesting Issue related with harvesting P3 Issue Minor defect in aesthetics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants