Aggegate bonded - Failure_Core_Future_Deadline

[cryptoBeliever]

Steps:

1. Change system clock +1h
2. Try to send aggregate bonded transaction (for example multisig)

Result: Announcing hash lock failes with error "Failure_Core_Future_Deadline":

Questions:

1. Why Hash lock transaction deadline is set to 6 hours? Hash lock is confirmed immediately. Why it has 6h instead of 2h like a normal transaction?

2. When the user operating system clock is ahead 1minute (or node clock 1minute behind) the user gets an error as above. I assume here that the max deadline for the hash lock is 6h but it seems correct assumption.

3. Wouldn't better to use node time (/node/time) instead of local user time?

[fboucquez]

Some notes:

1. 6 hours hash lock deadline is too long and top limit, the user is not going to wait for 6 hours before the wallet announces the bonded transaction.
   https://github.com/nemgrouplimited/symbol-desktop-wallet/blob/96b1678b5943b631299511d165d074f4a1219e35/src/services/TransactionCommand.ts#L173
   It could be the default 2 hours or even less.

2. 48 hours bonded is the top limit, the network may reject when the local time is slightly unsynchronized.
   https://github.com/nemgrouplimited/symbol-desktop-wallet/blob/96b1678b5943b631299511d165d074f4a1219e35/src/services/TransactionCommand.ts#L162
   Both 6 and 48 hours should be wallet configuration, not hardcoded.

3. I've created a service in the SDK that offsets any error. The wallet could create and share the service each time the repo factory is created via stores.
   feat: DeadlineService symbol-sdk-typescript-javascript#790
   The wallet could use DeadlineService.createDeadlineUsingOffset.

[coiki]

@surekabpm seems like this task was automatically moved to the Issue Backlog after you reopened it. Can you confirm it needs to be reopened?

[surekabpm]

This one by mistake I closed it and later have to reopen

[cryptoBeliever]

This should be tested after code review.

[cryptoBeliever]

@bassemmagdy announcing transaction doesn't work:

[bassemmagdy]

@cryptoBeliever please provide some steps to reproduce.

[postoronnii]

@bassemmagdy Create multisig account with 2 co-signors and initiate transaction from multisig account.

[cryptoBeliever]

Previous error I'm not able reproduce but now I can see errors with Timestamp too far in the future after a few tries of sending:

https://share.getcloudapp.com/z8uOGz6m

[cryptoBeliever]

Still got occasionally errors like this (but hard to reproduce exact steps):

Also, sdk is not released (alpha version used) so my suggestion is not to include in the next wallet release.

[cryptoBeliever]

@bassemmagdy looks like the number of API calls to the /time endpoint is too big. Please check video:
https://share.getcloudapp.com/Apu9WrYr

Maybe wallet should have only time synchronization periodically called like once per minute?

[cryptoBeliever]

As we discussed on the daily meeting there will be a change regarding time synchronization with a node. To avoid frequently ask /time endpoint.

[cryptoBeliever]

https://github.com/symbol/symbol-sdk-typescript-javascript/blob/81f5397b6f2db1d1c3eea15d3e8a41b6b82ae31f/src/service/DeadlineService.ts#L64

localTimeOffset and createDeadlineUsingOffset

Allow to calculate "server" deadlines without calling /time endpoint each time.

We should probably also refresh server time each X minutes (like 5) and when user switch node.

[cryptoBeliever]

All issues fixed 👍

[cryptoBeliever]

@bassemmagdy please merge into dev.