Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News feed doesn't work #1592

Closed
cryptoBeliever opened this issue Jul 14, 2021 · 4 comments · Fixed by #1623
Closed

News feed doesn't work #1592

cryptoBeliever opened this issue Jul 14, 2021 · 4 comments · Fixed by #1623
Assignees
Labels
P2 Issue Feature or UI issue preventing an action, Incomplete process or crashing during action

Comments

@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Jul 14, 2021

Currently, the news feed is not loading in the desktop wallet.

It's because in wallet is defined /nemflash which is proxy to https://nemgrouplimited.github.io/symbol-news/
Code:
https://github.com/nemgrouplimited/symbol-desktop-wallet/blob/96b1678b5943b631299511d165d074f4a1219e35/vue.config.js#L84

Currently, the repo was moved to symbol organization.

What has to be done:

@cryptoBeliever cryptoBeliever added the P2 Issue Feature or UI issue preventing an action, Incomplete process or crashing during action label Jul 14, 2021
@coiki
Copy link

coiki commented Jul 15, 2021

@bassemmagdy proposes to have a redirect of the old project to the new project so older wallets (installbase) are able to see news. If Github project is removed, News will be dead for any wallet that doesn’t update.

@0x6861746366574 do you reckon we can keep the old repo? for the next sprint (maybe even hotfix) we will change it to the new project.

@0x6861746366574
Copy link

@coiki Yeah, no reason not to - a fork should be enough, no?

@cryptoBeliever
Copy link
Contributor Author

@bassemmagdy there is a temporary fix that we still kept https://nemgrouplimited.github.io/symbol-news/.
Anyway, please update the link in the wallet to include in the next release.
Thanks

bassemmagdy added a commit that referenced this issue Aug 4, 2021
@bassemmagdy bassemmagdy linked a pull request Aug 4, 2021 that will close this issue
AnthonyLaw pushed a commit that referenced this issue Aug 6, 2021
@cryptoBeliever
Copy link
Contributor Author

News feed works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Issue Feature or UI issue preventing an action, Incomplete process or crashing during action
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants