Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add account -> invalid error message when provided private key not valid #1614

Closed
cryptoBeliever opened this issue Jul 22, 2021 · 2 comments · Fixed by #1641
Closed

Add account -> invalid error message when provided private key not valid #1614

cryptoBeliever opened this issue Jul 22, 2021 · 2 comments · Fixed by #1641
Assignees
@cryptoBeliever
Labels
P3 Issue Minor defect in aesthetics

Comments

@cryptoBeliever
Copy link
Contributor

Steps:

  1. Login to existing profile
  2. Go to "Accounts"
  3. Click "Add an account"
  4. Put account name
  5. Put invalid private key (with valid length). For example: 000000000000000000000000000000000000000000000000000000000000000q
  6. Put the password

Result: You got an error message: "Profile name already taken" which is confusing for the user. The message should tell that provided private key is invalid. When you click "Confirm" you got an error that an error happened and to try again.

Expected result: If the user provides invalid private key, present error message that pk is invalid and don't allow click "Confirm"

image
image
@cryptoBeliever cryptoBeliever added the P3 Issue Minor defect in aesthetics label Jul 22, 2021
@cryptoBeliever cryptoBeliever self-assigned this Aug 4, 2021
cryptoBeliever added a commit that referenced this issue Aug 5, 2021
@cryptoBeliever
Fix private key validation when adding new account into profile #1614
5def002
@cryptoBeliever cryptoBeliever mentioned this issue Aug 5, 2021
Merged
@cryptoBeliever cryptoBeliever linked a pull request Aug 5, 2021 that will close this issue
Fix private key validation when adding new account into profile #1614 #1641
Merged
cryptoBeliever added a commit that referenced this issue Aug 5, 2021
@cryptoBeliever
fix: private key validation when adding new account into profile #1614 …
bb0889f 
…- lint
cryptoBeliever added a commit that referenced this issue Aug 5, 2021
@cryptoBeliever
fix: private key validation when adding new account into profile #1614 …
ba34820 
…- improved translations
AnthonyLaw pushed a commit that referenced this issue Aug 6, 2021
@cryptoBeliever
Fix private key validation when adding new account into profile #1614 (…
545a603 
…#1641)

* Fix private key validation when adding new account into profile #1614

* fix: private key validation when adding new account into profile #1614 - lint

* fix: private key validation when adding new account into profile #1614 - improved translations
@cryptoBeliever
Copy link
Contributor Author

There is problem when trying add account with type = child account

cryptoBeliever added a commit that referenced this issue Aug 6, 2021
@cryptoBeliever
fix: private key validation when adding new account into profile #1614 …
e9fd736 
…- checking private key only if required
cryptoBeliever added a commit that referenced this issue Aug 8, 2021
@cryptoBeliever
fix: private key validation when adding new account into profile #1614 …
474c521 
…- checking private key only if required (#1643)
@cryptoBeliever
Copy link
Contributor Author

Fixed in dev branch.

@bassemmagdy bassemmagdy mentioned this issue Aug 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cryptoBeliever cryptoBeliever

Labels
P3 Issue Minor defect in aesthetics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix private key validation when adding new account into profile #1614 symbol/desktop-wallet
1 participant
@cryptoBeliever