Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leading zeros are ignored if there is no decimal point #1730

Closed
cryptoBeliever opened this issue Oct 4, 2021 · 1 comment · Fixed by #1785
Closed

Leading zeros are ignored if there is no decimal point #1730

cryptoBeliever opened this issue Oct 4, 2021 · 1 comment · Fixed by #1785
Assignees
@bassemmagdy
Labels
P2 Issue Feature or UI issue preventing an action, Incomplete process or crashing during action

Comments

@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Oct 4, 2021 •
edited
Loading

Steps:

  1. Go to transfer view
  2. Put amount "0001000"
  3. Go to sign pop-up view

Result:
Amount is changed to 1000 XYM.

Expected result:
Such value should be rejected. The user could do mistake and forget the decimal point. We can easly fix that by rejecting such values.
@cryptoBeliever cryptoBeliever added P2 Issue Feature or UI issue preventing an action, Incomplete process or crashing during action P3 Issue Minor defect in aesthetics and removed P3 Issue Minor defect in aesthetics labels Oct 4, 2021
@bassemmagdy bassemmagdy self-assigned this Oct 12, 2021
bassemmagdy added a commit that referenced this issue Oct 12, 2021
@bassemmagdy
fix #1730
24ea698
@bassemmagdy bassemmagdy mentioned this issue Oct 12, 2021
Closed
@cryptoBeliever
Copy link
Contributor Author

Fixed in PR #1736 👍

bassemmagdy added a commit that referenced this issue Nov 25, 2021
@bassemmagdy
fix #1674
2927792 
fix #1730

fix #1663
@bassemmagdy bassemmagdy mentioned this issue Nov 25, 2021
Merged
bassemmagdy added a commit that referenced this issue Nov 25, 2021
@bassemmagdy
fix #1674
6110b53 
fix #1730

fix #1663
bassemmagdy added a commit that referenced this issue Nov 25, 2021
@bassemmagdy
fix #1674 (#1785)
a112dc7 
fix #1730

fix #1663
This was referenced Nov 26, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassemmagdy bassemmagdy

Labels
P2 Issue Feature or UI issue preventing an action, Incomplete process or crashing during action
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

p2s issues fixes symbol/desktop-wallet
P2 issues fixes symbol/desktop-wallet
2 participants
@bassemmagdy @cryptoBeliever