Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password change related bugfixes #195

Closed
2 of 3 tasks
cryptoBeliever opened this issue Apr 2, 2020 · 4 comments
Closed
2 of 3 tasks

Password change related bugfixes #195

cryptoBeliever opened this issue Apr 2, 2020 · 4 comments
Assignees
@decentraliser
Labels
story-3 3 Story Points under review
Milestone
Release Candidate

Comments

@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Apr 2, 2020 •
edited by decentraliser
Loading

  • An profile's wallet array sometimes get emptied when the password is updated
  • Wallets password (SimpleWallet) do not get updated when a profile password is updated
  • When having a profile A and B, and changing password for B, B's new password is needed to login with A
@decentraliser decentraliser self-assigned this Apr 3, 2020
@decentraliser decentraliser added story-2 2 Story Points bug needs reproduction This issue has not be reproduced yet, may need more information and removed bug story-2 2 Story Points labels Apr 3, 2020
@decentraliser
Copy link
Contributor

@cryptoBeliever I tried to break it in all possible ways, on web and exe build, it looks fine to me

Could you please try again and confirm that it is really broken on your end?

@decentraliser decentraliser added bug story-2 2 Story Points and removed needs reproduction This issue has not be reproduced yet, may need more information labels Apr 3, 2020
@decentraliser
Copy link
Contributor

decentraliser commented Apr 3, 2020 •
edited
Loading

I have profile A and B, with the same password: password

I change profile B's password to newPassword

I now have to use newPassword to login with A
I have to use password to send a transaction with A

@decentraliser
Copy link
Contributor

Sometimes the wallets array gets emptied in the profile table...

@decentraliser decentraliser added story-3 3 Story Points and removed story-2 2 Story Points labels Apr 3, 2020
@decentraliser decentraliser changed the title Can't login after password change Password change related bugfixes Apr 3, 2020
@cryptoBeliever
Copy link
Contributor Author

cryptoBeliever commented Apr 3, 2020 •
edited
Loading

@decentraliser

I'm able to reproduce this in incognito to remove all wallets.

  1. Open wallet in incognito mode (web version).
  2. Create account aaa with password gggggg123
  3. Logout (this seems to be important part)
  4. Login
  5. Change password to hhhhhh123
  6. Logout
  7. I'm not able to login using new or old password.

decentraliser added a commit that referenced this issue Apr 3, 2020
@decentraliser
wallet password update bugfixes, fixes #195
e4dfdca
@evias evias added this to the Release Candidate milestone Apr 3, 2020
decentraliser added a commit that referenced this issue Apr 5, 2020
@decentraliser
wallet password update bugfixes, fixes #195
0bee541
@evias evias closed this as completed in c2703c4 Apr 6, 2020
@cryptoBeliever cryptoBeliever mentioned this issue Jan 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@decentraliser decentraliser

Labels
story-3 3 Story Points under review
Projects
None yet
Milestone
Release Candidate
Development

No branches or pull requests
3 participants
@evias @cryptoBeliever @decentraliser