regression bug fixing #1680
regression bug fixing #1680
Conversation
bassemmagdy
requested review from
AnthonyLaw,
yilmazbahadir and
cryptoBeliever
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -602,6 +602,7 @@ export class FormTransferTransactionTs extends FormTransactionBase { | |||
| @Watch('selectedSigner') | |||
| onSelectedSignerChange() { | |||
| this.formItems.signerAddress = this.selectedSigner.address.plain(); | |||
| this.resetForm(); | |||
There was a problem hiding this comment.
Wouldn't this break this change? => #1642
Should we just update the necessary parts instead?
There was a problem hiding this comment.
nope, it wouldn't break it. After having this sticky account feature it works as expected.
There was a problem hiding this comment.
After sending from multisig "From" selector stays selected on previously choosen multisig.
There was a problem hiding this comment.
Let's say as a user, I filled the transfer form and then noticed that I've chosen the wrong account, currently, all the other fields remain the same when I changed the signer but with this change, I'll have to re-enter all the information since it'll reset the form, right? I'm not sure if that's the behaviour we want to have in the transfer form tbh, @cryptoBeliever @coiki any ideas?
There was a problem hiding this comment.
As we need the form to be reactive especially when it comes to the held mosaics in each account, I believe we need to reset fields on the change of signer.
There was a problem hiding this comment.
@yilmazbahadir you are right. I thought about other case here.
@bassemmagdy would be possible to refresh only mosaics?
There was a problem hiding this comment.
we can only reset the held mosaics (dropdown and maybe the amount - unsure) rather than resetting the form, right? (If it won't break the reactivity ofc)
Should we just update the necessary parts instead?
There was a problem hiding this comment.
Form is cleaned after tx confirm. So we have regression with this fix -> #1577
Fixing: