Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explorer - URL tied to profile #1766

Closed
cryptoBeliever opened this issue Nov 11, 2021 · 2 comments · Fixed by #1784
Closed

Explorer - URL tied to profile #1766

cryptoBeliever opened this issue Nov 11, 2021 · 2 comments · Fixed by #1784
Assignees
@bassemmagdy

Comments

@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Nov 11, 2021 •
edited
Loading

Currently, when we change the URL for explorer for old profiles old URL stays.

Why it's saved on profile level? To allow edit it? @coiki do you think anyone is using this option?

My propositions:

  • remove the possibility to edit explore link or
  • provide versioning. If the version increases then overwrite URL stored on profile level with current one.

image

@coiki what you think about that?
@coiki
Copy link

coiki commented Nov 17, 2021

@cryptoBeliever I agree that this makes more sense at client-level (in the app) rather than at profile level.

Are we sure other products don't have dependency on this? If it's only local let's remove it from here and send it to settings.

For the existing URLs I would push for a migration in the next release. Let's start with letting the community know about the good practice of keeping that URL up-to-date.

bassemmagdy added a commit that referenced this issue Nov 17, 2021
@bassemmagdy
replace old explorer url with the new one and remove edit option #1766
7c2de3b
@bassemmagdy bassemmagdy mentioned this issue Nov 17, 2021
Closed
@bassemmagdy bassemmagdy self-assigned this Nov 17, 2021
@cryptoBeliever
Copy link
Contributor Author

Fixed in PR #1775

bassemmagdy added a commit to bassemmagdy/symbol-desktop-wallet that referenced this issue Nov 24, 2021
@bassemmagdy
replace old explorer url with the new one and remove edit option symb…
4bb6cf9 
…ol#1766
bassemmagdy added a commit that referenced this issue Nov 24, 2021
@bassemmagdy
- replace old explorer url with the new one and remove edit option #1766
840ac21 


- remove explorer url from settings storage
bassemmagdy added a commit to bassemmagdy/symbol-desktop-wallet that referenced this issue Nov 24, 2021
@bassemmagdy
replace old explorer url with the new one and remove edit option symb…
27194ec 
…ol#1766
@bassemmagdy bassemmagdy mentioned this issue Nov 24, 2021
Merged
bassemmagdy added a commit to bassemmagdy/symbol-desktop-wallet that referenced this issue Nov 25, 2021
@bassemmagdy
replace old explorer url with the new one and remove edit option symb…
36c1ed1 
…ol#1766
bassemmagdy added a commit that referenced this issue Nov 25, 2021
@bassemmagdy
replace old explorer url with the new one and remove edit option #1766 (
5fd4ef0 
#1784)
This was referenced Nov 26, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassemmagdy bassemmagdy

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@coiki @bassemmagdy @cryptoBeliever