Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace old explorer url with the new one and remove edit option #1766 #1784

Merged
merged 1 commit into from
Nov 25, 2021
Merged

replace old explorer url with the new one and remove edit option #1766 #1784

merged 1 commit into from
Nov 25, 2021

Conversation

bassemmagdy
Copy link
Contributor

fixes #1766

@bassemmagdy bassemmagdy mentioned this pull request Nov 24, 2021
Closed
@lgtm-com
Copy link

lgtm-com bot commented Nov 24, 2021

This pull request introduces 1 alert when merging 27194ec into bfc23ba - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@yilmazbahadir
Copy link
Contributor

Good job mate. After fixing the LGTM issue, I think we can approve & merge.

@cryptoBeliever
Copy link
Contributor

From my side all good 👍

@sonarcloud
Copy link

sonarcloud bot commented Nov 25, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bassemmagdy
Copy link
Contributor Author

@yilmazbahadir LGTM issues fixed.

@bassemmagdy bassemmagdy merged commit 5fd4ef0 into symbol:dev Nov 25, 2021
@bassemmagdy bassemmagdy mentioned this pull request Dec 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yilmazbahadir yilmazbahadir yilmazbahadir approved these changes

@OlegMakarenko OlegMakarenko Awaiting requested review from OlegMakarenko

@AnthonyLaw AnthonyLaw Awaiting requested review from AnthonyLaw

@cryptoBeliever cryptoBeliever Awaiting requested review from cryptoBeliever

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explorer - URL tied to profile
3 participants
@bassemmagdy @yilmazbahadir @cryptoBeliever