[wallet/desktop] feat: added nyc intg, enabled ci coverage check #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yilmazbahadir
requested review from
Jaguar0625,
0x6861746366574 and
gimre-xymcity
Jaguar0625
reviewed
Jun 9, 2022
scripts/ci/test.sh
Outdated
|
|
||
| # copy jest coverage json report to .nyc_output so that ci coverage threshold check can work | ||
| cd $(git rev-parse --show-toplevel) | ||
| mkdir -p .nyc_output && cp ./coverage/coverage-final.json ./.nyc_output 2>/dev/null || : |
Jaguar0625
previously approved these changes
Jun 9, 2022
yilmazbahadir
force-pushed
the
feature/ci-nyc-coverage-integration
branch
from
8e7fccd
to
0075a8e
Compare
|
Thanks for the review @Jaguar0625, merging now as I just pushed a newline fix after your approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the issue?
desktop-walletis using Jest test runner and CI was usingnycto check target the coverage threshold, needed to find a way to integrate these twoWhat's the fix
nycto be able to check if the minimum target coverage is met in the CI