unit test enhancements #1871
Merged
unit test enhancements #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 26, 2022 14:47
…lay, public key display etc. tests added Added/updated unit tests for the following components: AccountMetadataDsiplay, AccountMultisigGraph, AccountNameDisplay, AccountPublicKeyDisplay, AccountRestrictionsList, AccountFieldSelector, AccountSignerSelector
Codecov Report
@@ Coverage Diff @@
## dev #1871 +/- ##
==========================================
+ Coverage 20.76% 25.58% +4.82%
==========================================
Files 597 591 -6
Lines 13827 14022 +195
Branches 2173 2372 +199
==========================================
+ Hits 2871 3588 +717
+ Misses 10953 10349 -604
- Partials 3 85 +82
Flags with carried forward coverage won't be shown. Click here to find out more.
|
yilmazbahadir
requested review from
Jaguar0625,
0x6861746366574 and
gimre-xymcity
gimre-xymcity
previously approved these changes
Jul 11, 2022
| namespaced: true, | ||
| getters: { | ||
| explorerUrl: () => 'http://testnet.symbol.fyi/', | ||
| faucetUrl: () => 'http://https://testnet.symbol.tools/', |
There was a problem hiding this comment.
Thanks mate, fixed. Your review's gone to stale unfortunately.
…to plain AccountMetadataDisplay test is refactored
yilmazbahadir
force-pushed
the
feature/unit-test-enhancements
branch
from
f015efd
to
92bbbcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the issue?
Unit test coverage was too low (~22%).
What's the fix?