Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet/desktop] fix: multisig graph sorting issue #1890

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

OlegMakarenko
Copy link
Contributor

Problem

The AccountMultisigGraph dataset getter causes a side effect by mutating multisigAccountGraphInfo from Account state.

Solution

Copy multisigAccountGraphInfo members to new array.

@OlegMakarenko OlegMakarenko marked this pull request as ready for review August 12, 2022 16:57
@codecov-commenter
Copy link

Codecov Report

Merging #1890 (23668e6) into dev (8334bb5) will increase coverage by 0.62%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1890      +/-   ##
==========================================
+ Coverage   25.58%   26.20%   +0.62%     
==========================================
  Files         591      591              
  Lines       14022    14068      +46     
  Branches     2372     2377       +5     
==========================================
+ Hits         3588     3687      +99     
+ Misses      10349    10297      -52     
+ Partials       85       84       -1     
Flag Coverage Δ
wallet-desktop 26.20% <100.00%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ents/AccountMultisigGraph/AccountMultisigGraph.vue 100.00% <ø> (ø)
...accounts/AccountDetailsPage/AccountDetailsPage.vue 100.00% <ø> (+100.00%) ⬆️
...nts/AccountMultisigGraph/AccountMultisigGraphTs.ts 100.00% <100.00%> (ø)
src/store/Account.ts 11.11% <100.00%> (+5.83%) ⬆️
...ccounts/AccountDetailsPage/AccountDetailsPageTs.ts 33.66% <100.00%> (+33.66%) ⬆️
...ImportanceScoreDisplay/ImportanceScoreDisplayTs.ts 26.66% <0.00%> (+26.66%) ⬆️
.../ImportanceScoreDisplay/ImportanceScoreDisplay.vue 100.00% <0.00%> (+100.00%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants