[wallet/desktop]: jest clear cache added to npm test scripts #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yilmazbahadir
requested review from
0x6861746366574,
gimre-xymcity and
Jaguar0625
| "test": "TZ=UTC vue-cli-service test:unit", | ||
| "test:jenkins": "TZ=UTC vue-cli-service test:unit --coverage", | ||
| "test": "npm run jestClearCache && TZ=UTC vue-cli-service test:unit --testTimeout=30000", | ||
| "test:jenkins": "npm run jestClearCache && TZ=UTC vue-cli-service test:unit --coverage --testTimeout=30000", |
There was a problem hiding this comment.
is there any test taking longer than 10s?
There was a problem hiding this comment.
there was, complex UI page unit tests such as FormPersistentDelegationRequestTransaction could take more than 15s depending on the running machine.
yilmazbahadir
force-pushed
the
fix/unit-test-clear-cache
branch
from
36ce477
to
2ccecf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the issue?
Unit tests were failing due to unclean jest cache.
What is the fix?
jest cache is being cleared before npm unit test scripts.