fix: clean up stale nodes from database #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yilmazbahadir
force-pushed
the
fix/gh_122-clean-up-stale-nodes-from-db
branch
from
e43779d
to
9745334
Compare
yilmazbahadir
requested review from
AnthonyLaw,
OlegMakarenko,
0x6861746366574,
gimre-xymcity and
Jaguar0625
gimre-xymcity
approved these changes
Jan 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #122
What is the fix?
node.apiStatus.isAvailableandnode.peerStatus.isAvailablefields according to thenode's roleand storelastAvailable(type: Date)field in thenodescollection.monitor.KEEP_STALE_NODES_FOR_HOURS(default 3 days - configurable via environment variable) is met then remove from thenodescollection if still unavailable.