Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate Relationals when casting to bool #354

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Evaluate Relationals when casting to bool #354

wants to merge 9 commits into from

Commits on Jun 4, 2021

  1. Override __bool__ in Relational, so that it returns whatever the bool… 

    …ean evaluation is, instead of always True. Resolves symengine#312
    @qthequartermasterman
    qthequartermasterman committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    a96e507 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2021

  1. Update test_eval.py 

    Fixed incorrect evaluation test. To get rid of a sin(x)**2, we need to subtract sin(x)**2, not x**2.
    @qthequartermasterman
    qthequartermasterman committed Jun 5, 2021
    Configuration menu
    Copy the full SHA
    290f916 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2021

  1. Improved speed of boolean evaluation.

    @qthequartermasterman
    qthequartermasterman committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    8709957 View commit details
    Browse the repository at this point in the history

  2. Added tests for Equality

    @qthequartermasterman
    qthequartermasterman committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    4090967 View commit details
    Browse the repository at this point in the history

  3. Added Tests for Unequality, Less than, and Greater Than.

    @qthequartermasterman
    qthequartermasterman committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    f81c74a View commit details
    Browse the repository at this point in the history

  4. Fixed boolean evaluation for Less Than and Greater Than.

    @qthequartermasterman
    qthequartermasterman committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    afa4925 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2021

  1. Include workaround for environments without sympy.

    @qthequartermasterman
    qthequartermasterman committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    feaeca0 View commit details
    Browse the repository at this point in the history

  2. Fix tests so that they will accept a ValueError for hard relational e… 

    …valuations.
    @qthequartermasterman
    qthequartermasterman committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    1d4d0e9 View commit details
    Browse the repository at this point in the history

  3. Eliminated all approximations in Relational boolean evaluation. Raise… 

    … a ValueError if simplification is unclear.
    @qthequartermasterman
    qthequartermasterman committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    cf784eb View commit details
    Browse the repository at this point in the history