-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cython syntax, add tests #481
Conversation
added 7472cce since building with cython master gives:
|
Added dd3dc6e since it fixes gh-483 The |
Following the explanation in sympy/sympy#26645 (comment)
I think that the premise of this test is incorrect: symengine.py/symengine/tests/test_sympy_conv.py Lines 771 to 772 in b87a4a2
It should be a TypeError to sympify a domain element. Many other domain/polys types in SymPy inherit $ git grep CantSympify sympy/polys/
sympy/polys/fields.py:from sympy.core.sympify import CantSympify, sympify
sympy/polys/fields.py:class FracElement(DomainElement, DefaultPrinting, CantSympify):
sympy/polys/polyclasses.py:from sympy.core.sympify import CantSympify
sympy/polys/polyclasses.py:class DMP(CantSympify):
sympy/polys/polyclasses.py:class DMF(PicklableWithSlots, CantSympify):
sympy/polys/polyclasses.py:class ANP(CantSympify):
sympy/polys/rings.py:from sympy.core.sympify import CantSympify, sympify
sympy/polys/rings.py:class PolyElement(DomainElement, DefaultPrinting, CantSympify, dict): I consider it an oversight that |
See gh-480 and cython/cython#6218
Fixes #480
Fixes #483