Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide which ruby versions to support #48

Open
isuruf opened this issue Jun 1, 2016 · 5 comments
Open

Decide which ruby versions to support #48

isuruf opened this issue Jun 1, 2016 · 5 comments
Milestone

Comments

@isuruf
Copy link
Member

isuruf commented Jun 1, 2016

In travis, we test,

  • 1.9.3
  • 2.0
  • 2.1
  • 2.2
  • 2.3.0

We initially included these because these were the ones supported in NMatrix I think.

Since official support for 1.9.3 is stopped including security patches, I'm okay with dropping 1.9.3. What do you think?

@zverok, @certik, @abinashmeher999, @rajithv, @MohawkJohn, @v0dro

@zverok
Copy link
Collaborator

zverok commented Jun 1, 2016

I'd boldly say that 2.0 should go away too.
It is already deprecated, and 2.1 have significantly superior features (keyword arguments and refinements), and as SymEngine is more than any other SciRuby project needs clean modern API, ...

@v0dro
Copy link

v0dro commented Jun 1, 2016

I'd still say go with ruby 2+ for now and then drop support by the end of the year.

@abinashmeher999
Copy link
Contributor

Since 1.9.3 is the only one that is making us take extra effort to write
compatible code, that should be the one to go first. One of the tests for
1.9.3 fails on OS X too.

For 2.0 we haven't had any problems yet, I think. Let us keep the tests for
2.0 for now and when we come across another issue where something is not
supported in 2.0 we can drop it then.

On Wed, Jun 1, 2016, 1:25 PM Sameer Deshmukh notifications@github.com
wrote:

I'd still say go with ruby 2+ for now and then drop support by the end of
the year.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#48 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AGmQ6zgn8zcLjQxHpJ0YrE5v6Bium4iUks5qHTsDgaJpZM4IrQ2r
.

@certik
Copy link
Contributor

certik commented Jun 1, 2016

Let's drop 1.9.3. since it doesn't receive security patches. We can
probably drop 2.0 as well, but we can also be conservative and drop it a
bit later.

Sent from my mobile phone.
On Jun 1, 2016 9:32 AM, "Isuru Fernando" notifications@github.com wrote:

In travis, we test,

  • 1.9.3
  • 2.0
  • 2.1
  • 2.2
  • 2.3.0 We initially included these because these were the ones
    supported in NMatrix I think.

Since official support for 1.9.3 is stopped including security patches,
I'm okay with dropping 1.9.3. What do you think?

@zverok https://github.com/zverok, @certik https://github.com/certik,
@abinashmeher999 https://github.com/abinashmeher999, @rajithv
https://github.com/rajithv, @MohawkJohn https://github.com/mohawkjohn,
@v0dro https://github.com/v0dro


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#48, or mute the thread
https://github.com/notifications/unsubscribe/AABQWCc4aGKtICbaC_nyx2Br5Zh0n2BAks5qHTV4gaJpZM4IrQ2r
.

@isuruf
Copy link
Member Author

isuruf commented Oct 8, 2016

Seems 2.0 also doesn't receive security patches. We should drop 2.0 as well.

@isuruf isuruf added this to the Release 0.1.0 milestone Oct 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants