Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the commit revision to binary/reports/docker #255

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

Munsio
Copy link
Contributor

@Munsio Munsio commented Jul 10, 2024

No description provided.

@Munsio Munsio force-pushed the 207-add-revision-to-everything branch 2 times, most recently from 6b5d161 to bb027ff Compare July 10, 2024 13:50
@Munsio Munsio marked this pull request as ready for review July 11, 2024 06:38
@Munsio Munsio requested a review from ruiAzevedo19 July 11, 2024 06:38
@Munsio
Copy link
Contributor Author

Munsio commented Jul 11, 2024

@ruiAzevedo19 please review

Testing the revision with the binary and a golang test itself would mean to run system tests which we currently do not have. Therefore the normal test with the check for development is the only one.

The docker image one can be reviewed here: https://github.com/symflower/eval-dev-quality/actions/runs/9875489063/job/27272302420?pr=255#step:6:41
Please note that the Branch Commit hash and the PR commit hash are different (unfortunately) But we are building on Branches now too which you can check with: https://github.com/symflower/eval-dev-quality/actions/runs/9875489063/job/27272302420#step:6:41 This one has to be the same as the latest commit in the branch itself.

.github/workflows/docker.yml Show resolved Hide resolved
.github/workflows/branch.yml Show resolved Hide resolved
cmd/eval-dev-quality/cmd/version.go Outdated Show resolved Hide resolved
@ruiAzevedo19 ruiAzevedo19 added this to the v0.6.0 milestone Jul 11, 2024
@ruiAzevedo19 ruiAzevedo19 added the enhancement New feature or request label Jul 11, 2024
@Munsio Munsio force-pushed the 207-add-revision-to-everything branch from bb027ff to da131bf Compare July 11, 2024 10:09
@Munsio Munsio requested a review from ruiAzevedo19 July 11, 2024 10:10
@Munsio Munsio force-pushed the 207-add-revision-to-everything branch from da131bf to ecaf0b4 Compare July 11, 2024 10:11
@ruiAzevedo19
Copy link
Contributor

@bauersimon Please, do a second review

@Munsio Munsio requested a review from bauersimon July 11, 2024 13:42
Copy link
Member

@bauersimon bauersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome - tried it locally. works great

@bauersimon bauersimon self-requested a review July 12, 2024 07:44
@bauersimon bauersimon merged commit 16d55ab into main Jul 12, 2024
5 checks passed
@bauersimon bauersimon deleted the 207-add-revision-to-everything branch July 12, 2024 07:44
ruiAzevedo19 added a commit that referenced this pull request Jul 15, 2024
…e, to avoid unnecessary processes being opened

Closes #255
ruiAzevedo19 added a commit that referenced this pull request Jul 15, 2024
…e, to avoid unnecessary processes being opened

Closes #255
@bauersimon bauersimon mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants