-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the commit revision to binary/reports/docker #255
Conversation
6b5d161
to
bb027ff
Compare
@ruiAzevedo19 please review Testing the revision with the binary and a golang test itself would mean to run system tests which we currently do not have. Therefore the normal test with the check for The docker image one can be reviewed here: https://github.com/symflower/eval-dev-quality/actions/runs/9875489063/job/27272302420?pr=255#step:6:41 |
bb027ff
to
da131bf
Compare
da131bf
to
ecaf0b4
Compare
@bauersimon Please, do a second review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome - tried it locally. works great
…e, to avoid unnecessary processes being opened Closes #255
…e, to avoid unnecessary processes being opened Closes #255
No description provided.