New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing docker runtime #260

Merged

ruiAzevedo19 merged 5 commits into main from testing-docker-runtime

Jul 16, 2024

Contributor

Munsio commented Jul 11, 2024

No description provided.

Munsio force-pushed the testing-docker-runtime branch 3 times, most recently from 92f7f1e to f7b940f Compare

July 11, 2024 15:15

Munsio self-assigned this

Munsio added this to the v0.6.0 milestone

Munsio force-pushed the testing-docker-runtime branch from f7b940f to 87fb632 Compare

July 11, 2024 15:39

Munsio marked this pull request as ready for review

July 16, 2024 05:58

Munsio requested review from bauersimon and ruiAzevedo19

July 16, 2024 05:58

Munsio force-pushed the testing-docker-runtime branch 3 times, most recently from 4fb01b9 to c00dfcb Compare

July 16, 2024 08:29

bauersimon reviewed

View reviewed changes

Dockerfile Show resolved Hide resolved

bauersimon reviewed

View reviewed changes

cmd/eval-dev-quality/cmd/evaluate.go Show resolved Hide resolved

bauersimon reviewed

View reviewed changes

cmd/eval-dev-quality/cmd/evaluate.go Outdated Show resolved Hide resolved

bauersimon reviewed

View reviewed changes

cmd/eval-dev-quality/cmd/evaluate.go Outdated Show resolved Hide resolved

bauersimon reviewed

View reviewed changes

cmd/eval-dev-quality/cmd/evaluate_test.go Outdated Show resolved Hide resolved

Munsio force-pushed the testing-docker-runtime branch 2 times, most recently from 94d29c4 to 4348b5e Compare

July 16, 2024 12:52

Munsio added 3 commits

July 16, 2024 14:54


          fix, Update maven github action as it is using a deprecated NodeJS ve…

90ae209

…rsion following https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/


          fix, Ignore the testdata path when using a containerized runtime

0271c7d

because the paths of the host and inside the container might differ.


          Build the Docker image with a MultiStage build

a35b4bb

By using a MultiStage build we avoid copying the whole evaluation repository into the Docker image.
Also fixed some creations of folders and permissions regarding non-docker run containers.

Munsio force-pushed the testing-docker-runtime branch from 4348b5e to b8eb16e Compare

July 16, 2024 12:54

ruiAzevedo19 reviewed

View reviewed changes

Dockerfile Show resolved Hide resolved

ruiAzevedo19 reviewed

View reviewed changes

cmd/eval-dev-quality/cmd/evaluate_test.go Outdated Show resolved Hide resolved

Contributor

ruiAzevedo19 commented Jul 16, 2024

@Munsio Done with the review

Munsio added 2 commits

July 16, 2024 16:22


          Testing docker runtime inside the CI

2f79951

Closes #224


          Increase testing timeout from 8 to 12 minutes

638d20d

Munsio force-pushed the testing-docker-runtime branch from b8eb16e to 638d20d Compare

July 16, 2024 14:22

ruiAzevedo19 enabled auto-merge

July 16, 2024 14:27

ruiAzevedo19 merged commit 25e8d81 into main

5 checks passed

ruiAzevedo19 deleted the testing-docker-runtime branch

July 16, 2024 14:35

Munsio mentioned this pull request

unable to create temporary repository path: exec: WaitDelay expired before I/O complete #219

Closed

bauersimon added the CI label

bauersimon mentioned this pull request

Roadmap for v0.6.0 #195

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI