Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix, Define a timeout for the "symflower unit-tests" command, so ensure the execution does not take too much time #267

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

ruiAzevedo19
Copy link
Contributor

Part of #167

@ruiAzevedo19 ruiAzevedo19 added the bug Something isn't working label Jul 15, 2024
@ruiAzevedo19 ruiAzevedo19 added this to the v0.6.0 milestone Jul 15, 2024
@ruiAzevedo19 ruiAzevedo19 self-assigned this Jul 15, 2024
@ruiAzevedo19 ruiAzevedo19 force-pushed the 167-symflower-ut-timeout branch from e1ef5bf to 09876e5 Compare July 15, 2024 10:37
@ruiAzevedo19 ruiAzevedo19 changed the title Define a timeout for the "symflower unit-tests" command, so ensure the execution does not take too much time fix, Define a timeout for the "symflower unit-tests" command, so ensure the execution does not take too much time Jul 15, 2024
model/symflower/symflower_test.go Outdated Show resolved Hide resolved
model/symflower/symflower.go Outdated Show resolved Hide resolved
model/symflower/symflower.go Outdated Show resolved Hide resolved
model/symflower/symflower_test.go Outdated Show resolved Hide resolved
model/symflower/symflower_test.go Outdated Show resolved Hide resolved
model/symflower/symflower.go Outdated Show resolved Hide resolved
@ruiAzevedo19 ruiAzevedo19 force-pushed the 167-symflower-ut-timeout branch from 09876e5 to 87bef95 Compare July 16, 2024 10:31
@ruiAzevedo19 ruiAzevedo19 force-pushed the 167-symflower-ut-timeout branch 2 times, most recently from 4d91a50 to a23c87d Compare July 17, 2024 07:06
tools/symflower.go Outdated Show resolved Hide resolved
@ahumenberger ahumenberger force-pushed the 167-symflower-ut-timeout branch from a23c87d to 8a5de7e Compare July 18, 2024 04:14
@ahumenberger ahumenberger dismissed bauersimon’s stale review July 18, 2024 08:39

Feedback incorporated. Changes cannot be accepted by Simon since he's on vacation.

@ahumenberger ahumenberger merged commit acb0f6d into main Jul 18, 2024
5 checks passed
@ahumenberger ahumenberger deleted the 167-symflower-ut-timeout branch July 18, 2024 08:39
@bauersimon bauersimon mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants