Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP discovery on Windows uses current drive instead of system drive #16

Open
supervirus opened this issue Feb 15, 2024 · 1 comment
Open

PHP discovery on Windows uses current drive instead of system drive #16

supervirus opened this issue Feb 15, 2024 · 1 comment

Comments

@supervirus
Copy link

supervirus commented Feb 15, 2024 •
edited
Loading

Currently the function systemDir in discovery_windows.go return the current drive instead of the system drive.
For the majority of the developers this is no problem, as they only use a single drive for both Windows and projects.
In the future this can change, as Microsoft pushes developers to use DevDrives.

The system drive is available in the environment variable SystemDrive.
Using this environment variable instead of the current drive would reflect the behaviour of the Composer Windows installer, which the discovery is based on.

Affected version:
Symfony CLI version 5.8.11
@tucksaun
Copy link
Member

makes sense. willing to open a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@supervirus @tucksaun