Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling non-array return from route provider #279

Merged
merged 2 commits into from
Jul 4, 2022
Merged

Fix handling non-array return from route provider #279

merged 2 commits into from
Jul 4, 2022

Conversation

andrew-demb
Copy link
Contributor

Q A
Branch? "master" (it is not a new feature, but there is no release branch for 3.0)
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #278
License MIT
Doc PR n/a

dbu
dbu approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. we should start using phpstan on this repository ;-)

(if you want to introduce that to the build, i would appreciate it)

@dbu dbu merged commit feb9e87 into symfony-cmf:master Jul 4, 2022
@dbu dbu mentioned this pull request Jul 4, 2022
Closed
@andrew-demb andrew-demb deleted the respect-iterable-provider branch July 4, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew-demb @dbu