Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.0 compatibility #456

Closed
ausi opened this issue Nov 20, 2020 · 3 comments
Closed

PHP 8.0 compatibility #456

ausi opened this issue Nov 20, 2020 · 3 comments

Comments

@ausi
Copy link
Contributor

ausi commented Nov 20, 2020

Are there any plans for adding compatibilty with PHP 8.0?

Would you like me to create a pull request for this?
@ausi ausi mentioned this issue Nov 20, 2020
Closed
42 tasks
@dbu
Copy link
Member

dbu commented Nov 20, 2020

hi, i'd appreciate help, yes. i started with updating some of the dependencies. we need to run tests with phpcr-odm which is upadting in doctrine/phpcr-odm#817 but that is blocked by jackalope/jackalope-doctrine-dbal#373 which is a bit more effort... if you have time to look into the doctrine-dbal upgrades that would be awesome (but i am aware that this is more involved than "just" allowing php 8 ;-) )

@blankse blankse mentioned this issue Dec 2, 2020
Merged
@blankse
Copy link
Contributor

blankse commented Dec 2, 2020

I see the issue too late :) I created an PR, but yes is blocked by jackalope/jackalope-doctrine-dbal

@ausi
Copy link
Contributor Author

ausi commented Dec 3, 2020

Closed in favor of #457

@ausi ausi closed this as completed Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dbu @ausi @blankse