Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test with php 8 #817

Closed
wants to merge 1 commit into from
Closed

test with php 8 #817

wants to merge 1 commit into from

Conversation

dbu
Copy link
Member

@dbu dbu commented Oct 6, 2020

depends on the whole phpcr and jackalope ecosystem allowing php 8...

@SenseException
Copy link
Member

Is this still WIP?

@dbu
Copy link
Member Author

dbu commented Oct 7, 2020

@SenseException yes, look at the build error: some dependencies are not yet allowing php 8.
i started on phpcr/phpcr-utils#190 but now that one needs some adjustments for newer phpunit versions and i ran out of time. if you have time to have a look, that would help, otherwise i will try to look into it later this week.

@dbu
Copy link
Member Author

dbu commented Nov 20, 2020

the (hopefully) last blocker for this is jackalope/jackalope-doctrine-dbal#373

@dbu
Copy link
Member Author

dbu commented Jan 12, 2021

i merged php 8 support into the 1.5 branch and released 1.5.3

updating master from 1.5 in #819

@dbu dbu closed this Jan 12, 2021
@dbu dbu deleted the php-8 branch January 12, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants