Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8 #273

Closed
wants to merge 1 commit into from
Closed

Add support for PHP 8 #273

wants to merge 1 commit into from

Conversation

core23
Copy link
Member

@core23 core23 commented Dec 3, 2020

Changelog

### Added
- Added support for PHP 8

@core23
Copy link
Member Author

core23 commented Dec 3, 2020

Blocked by doctrine/phpcr-odm#817

@VincentLanglet
Copy link
Member

Blocked by doctrine/phpcr-odm#817

A doctrineORM user shouldn't be blocked by the Phpcr support of PHP 8.
Shouldn't we skip test related to PHPCR if PhpVersion is >= 8 ?

@core23
Copy link
Member Author

core23 commented Dec 3, 2020

It's a dev dependency, so it could be okay. If doing this, we should keep an eye on this to remove the temporary fix.

@franmomu
Copy link
Member

franmomu commented Dec 3, 2020

It's also blocked by the other persistence layers:

@VincentLanglet
Copy link
Member

Closed in favor of #284

We can keep running test with the 7.4.99 platform hack (for dev dependencies), and allow php8 in order to allow others sonata bundles running the ci without the 7.4.99 hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants