-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide initial compatibility with PHP 8 #2248
Conversation
7d4396c
to
4addfbc
Compare
Thank you! |
Note: I'll hold off on merging this until I've finished migrating the builds to GitHub actions. Can't rely on travis-CI anymore. |
4addfbc
to
e6b574d
Compare
Any news on this? I see that CI is running on github actions already |
I lost track of this but will revisit soon. Thanks for the reminder 👍 |
I've opened #2258 to track persistent collection changes |
I have merged |
e6b574d
to
ab6a784
Compare
ab6a784
to
af880aa
Compare
lib/Doctrine/ODM/MongoDB/Aggregation/Stage/GraphLookup/Match.php
Outdated
Show resolved
Hide resolved
lib/Doctrine/ODM/MongoDB/PersistentCollection/DefaultPersistentCollectionGenerator.php
Show resolved
Hide resolved
@malarzm I waited long enough to take care of proxies as well: we can now generate proxies with 7.4 language features on PHP 8 by switching to friendsofphp/proxy-manager-lts. Proxy support for PHP 8 features is still outstanding pending an upstream fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
@@ -22,17 +22,17 @@ | |||
{ "name": "Andreas Braun", "email": "alcaeus@alcaeus.org" } | |||
], | |||
"require": { | |||
"php": "^7.2", | |||
"php": "^7.2 || ^8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@malarzm can this PR be tagged so we can update to PHP 8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll try to have a release in January :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No hurry, I'm happy just with a plan 👍
Summary
This PR makes the code base compatible with PHP 8. A few caveats:
match
functionality in aggregation builder requires changing asmatch
is now a reserved keyword. This PR includes changes from Rename Match classes for PHP 8 compatibility #2237.ocramius/proxy-manager
is compatible with PHP 8 (see Allow PHP 8 Ocramius/ProxyManager#628) we need to runcomposer install
on PHP 8 with--ignore-platform-req=php
.