[WIP] Add Doctrine ORM support #148
Conversation
tgalopin
changed the title
| ->end() | ||
| ->end() | ||
| ->end() | ||
| */ |
There was a problem hiding this comment.
we need to either implement sonata or remove these commented out configuration parts
|
thanks a lot! i added some note about the things we said we still need to work on. |
| @@ -14,6 +14,7 @@ | |||
| "minimum-stability": "dev", | |||
| "require": { | |||
| "php": ">=5.3.9", | |||
| "doctrine/orm": "~2.2,>=2.2.3,<2.5", | |||
There was a problem hiding this comment.
Why not doctrine/orm 2.5? Tip: ~2.2,>2.2.3 can be replaced with ^2.2.3 https://getcomposer.org/doc/articles/versions.md#caret.
There was a problem hiding this comment.
this was taken straight from symfony standard edition 2.7:
https://github.com/symfony/symfony-standard/blob/2.7/composer.json#L12
but indeed, we should simply say ^2.2.3 and leave it to the
application to know if they have an issue with the orm or not.
There was a problem hiding this comment.
2.5 has a BC break with 2.4 with the setup used by the Symfony standard (you had to configure some new setting, otherwise the DB connection couldn't be made, breaking all Symfony pages, as connections were always made).
For a package, 2.5 can be completely valid. When changing to ^2.2.3, please also update the rest of the dependencies to all use the same operators (for consistency, I'm slowly upgrading all CMF packages to use ^ instead of ~).
|
It's been a while but I'm still planning to do this. I'm pretty busy right now with personnal stuff, but I'll work on this soon :) . |
|
I think we should remove the 1.3 milestone here. It's a very great feature (and one that I want to have in the CMF since 1.0), but 1.3 is coming too early to have this included. Furthermore, if we skip this for 2.0 (end of this year), we can add ORM support to more bundles and release them all at once. |
|
agreed its no blocker for 1.3, but if we manage to get it merged in time, i would not hold back in the hope of more orm support - we can also add it step by step |
|
ping @tgalopin |
|
I'm currently really drowning into work, so even if I planned to work on this, it's a way too big PR for me right now. If someone is interested in continuing the work, please do! Sorry :/ ! |
|
i think the code is still relevant. reopening - when somebody has time to wrap this up, this will be a good starting point. |
This pull request add the support of ORM in the SimpleCmsBundle.
It is a work in progress for the moment.