-
-
Notifications
You must be signed in to change notification settings - Fork 41
[Platform] Use JSON Path to convert responses #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: simplify-choice-handling
Are you sure you want to change the base?
Conversation
ed6eaea
to
7ec4f22
Compare
I really like the idea! Know that if you manage to get a resource for the response, JsonPath uses JsonStreamer to optimize the part to actually decode. Just in case 🙂 Given that JsonPath is experimental, I'd suggest changing the composer constraint to 7.3.*. That's what we do in core because experimental components may not be compatible between their minor versions. I have no plan to change classes or signatures in the JsonPath component until it's stable release as I managed to make it RFC compliant lately with the exact same API. But better be safe than sorry! |
Interesting approach! Do we even need the platform-specific EDIT: ok hmm I guess the idea was to encapsulate the "protocol" in the converter to be reused in different platforms |
8b26c09
to
4387b79
Compare
Thanks for that!
exactly |
4387b79
to
b820262
Compare
We just created some Thanks |
a5e2e28
to
b4ef6f5
Compare
eee446f
to
a5d834a
Compare
src/platform/src/Contract/JsonPathConverter/ResultExtractorInterface.php
Outdated
Show resolved
Hide resolved
2d2c547
to
459b7a3
Compare
459b7a3
to
afe308c
Compare
d927cce
to
abec2aa
Compare
708dd97
to
96f8c75
Compare
9aedbf3
to
9a76a18
Compare
ba0fcd0
to
34e7852
Compare
34e7852
to
eff76f7
Compare
This approach combines two ideas:
And of course those two things don't have to be coupled, but one thing led to the other somehow ...