Skip to content

[Store] Add commands to setup/drop a store #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2025
Merged

[Store] Add commands to setup/drop a store #335

merged 1 commit into from
Sep 5, 2025

Conversation

Guikingone
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
Docs? yes
Issues #330
License MIT

Hi 👋🏻

As discussed in #330, here's the commands required to setup/drop the stores, by default, I moved the commands in the Store component but wasn't sure about it.

@carsonbot carsonbot added Status: Needs Review Feature New feature Store Issues & PRs about the AI Store component labels Aug 20, 2025
@carsonbot carsonbot changed the title [Store]: ManagedStoreInterface commands added [Store] : ManagedStoreInterface commands added Aug 20, 2025
@Guikingone Guikingone changed the title [Store] : ManagedStoreInterface commands added [Store] ManagedStoreInterface commands added Aug 20, 2025
OskarStark
OskarStark reviewed Aug 20, 2025
View reviewed changes
OskarStark
OskarStark reviewed Aug 20, 2025
View reviewed changes
OskarStark
OskarStark reviewed Aug 20, 2025
View reviewed changes
OskarStark
OskarStark reviewed Aug 20, 2025
View reviewed changes
OskarStark
OskarStark reviewed Aug 20, 2025
View reviewed changes
OskarStark
OskarStark reviewed Aug 20, 2025
View reviewed changes
OskarStark
OskarStark reviewed Aug 20, 2025
View reviewed changes
@OskarStark OskarStark changed the title [Store] ManagedStoreInterface commands added [Store] Add commands to setup/drop a store Aug 20, 2025
@Guikingone Guikingone force-pushed the store/commands branch 2 times, most recently from 1ef933d to 30c5f2f Compare August 20, 2025 15:03
chr-hertel
chr-hertel reviewed Aug 20, 2025
View reviewed changes
chr-hertel
chr-hertel reviewed Aug 20, 2025
View reviewed changes
@chr-hertel
Copy link
Member

I moved the commands in the Store component but wasn't sure about it.

no no, that the right decision from my point of view 👍

@chr-hertel
Copy link
Member

Alright, let's talk about functional testing here - that's important to me with that amount of bridges we can't go with manual.

My first idea was to bring in simple store examples, that would setup, add, query and drop. but that would be super similar to the rag ones - well without the agent tho.
so a) we adopt be commands in those examples, b) we bring in new one with only those for operations, and c) $yourIdea 🤷‍♂️ 😆

@Guikingone
Copy link
Contributor Author

What about improving the rag examples by adding the drop calls when it's possible?

Maybe just before returning the content to the user?

Don't know if adding examples with commands brings any benefits to the user or we're talking about single-file commands that we can call in the existing examples 🤔

@OskarStark
Copy link
Contributor

I would keep the examples, but what about using setup and store in CI to see if they are working? Could be a follow up PR imho

@OskarStark
Copy link
Contributor

Docs are missing

@Guikingone Guikingone force-pushed the store/commands branch 2 times, most recently from 853094b to c1bcf91 Compare August 22, 2025 11:41
@chr-hertel
Copy link
Member

If we could shift it to GitHub actions, that would be fine as well - and it's true, that there is little benefit to users with examples only setup-add-query-drop, true.

We already skipped it in #328 - so we should bring it in now.

@OskarStark
Copy link
Contributor

Needs a rebase after

OskarStark
OskarStark reviewed Sep 3, 2025
View reviewed changes
@Guikingone Guikingone force-pushed the store/commands branch 2 times, most recently from 7dd3202 to f012430 Compare September 3, 2025 12:19
OskarStark
OskarStark reviewed Sep 3, 2025
View reviewed changes
@Guikingone Guikingone force-pushed the store/commands branch 2 times, most recently from 7f0f0d1 to b9a679c Compare September 3, 2025 12:51
@Guikingone Guikingone force-pushed the store/commands branch 5 times, most recently from 59cd8ee to 7f27fd9 Compare September 4, 2025 13:17
@Guikingone Guikingone mentioned this pull request Sep 5, 2025
Merged
OskarStark added a commit that referenced this pull request Sep 5, 2025
@OskarStark
bug #458 [Store] Fix Weaviate handling during drop (Guikingone)
93caf94 
This PR was merged into the main branch.

Discussion
----------

[Store] Fix Weaviate handling during drop

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| Docs?         | no
| Issues        | Related to #335
| License       | MIT

Small fix regarding the handling of `drop` (empty content).

Commits
-------

a982fe6 fix(store): weaviate
@OskarStark
Copy link
Contributor

Needs a rebase after

@Guikingone
Copy link
Contributor Author

Rebase done 👍🏻

@OskarStark
Copy link
Contributor

Thanks for your work on this new feature!

@OskarStark OskarStark merged commit 0bd8d96 into symfony:main Sep 5, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN left review comments

@Nyholm Nyholm Awaiting requested review from Nyholm Nyholm is a code owner

@welcoMattic welcoMattic Awaiting requested review from welcoMattic

@chr-hertel chr-hertel Awaiting requested review from chr-hertel chr-hertel is a code owner

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

Assignees
No one assigned
Labels
Feature New feature Status: Needs Review Store Issues & PRs about the AI Store component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Guikingone @chr-hertel @OskarStark @GromNaN @carsonbot