Add support for pagination #6
Conversation
you mean because everything is still in the collection anyways? |
Yes, But another implementation might have 1000 items and read them from disk or database. They could benefit. |
| public function __construct( | ||
| private readonly CollectionInterface $toolCollection, | ||
| private readonly CollectionInterface $collection, | ||
| private readonly int $pageSize = 20, |
There was a problem hiding this comment.
that introduces paging by default without the possibility to opt out, right?
well, one could set PHP_INT_MAX here, but what about allowing null to disable it?
anyhow, totally minor thing - valid to merge anyways
There was a problem hiding this comment.
Good point. Let's remember that we should fix this.
(I created an issue)
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\AI\McpSdk\Capability\Prompt; |
There was a problem hiding this comment.
Off topic, but what about using Mcp\Sdk as namespace?
There was a problem hiding this comment.
No "Symfony" prefix?
That would be a first for Symfony organization.
I do see they are long an ugly, but it follows Symfony UX' pattern
Just following the protocol.
Note that there is no real benefit with pagination for our standard Collection implementation