Remove declare() calls #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Yeah, sure. I was not sure why we do not declare strict types in the Symfony repo. |
Nyholm
approved these changes
May 29, 2025
Member
|
Thank you Fabien. |
chr-hertel
approved these changes
May 29, 2025
Member
chr-hertel
left a comment
chr-hertel
left a comment
There was a problem hiding this comment.
the benefit is small, as is the harm - don't have a strong take here
chr-hertel
added a commit
that referenced
this pull request
Jun 6, 2025
chr-hertel
added a commit
that referenced
this pull request
Jun 13, 2025
chr-hertel
pushed a commit
that referenced
this pull request
Jun 22, 2025
* moving classes to a more component like structure - add Wikipedia and YouTube namespace and moved applicable classes. this way the code is clustered by implementation making it easier to copy paste it to your own application. * rename rag to blog - rename add to blog to clarify the implementation
chr-hertel
added a commit
that referenced
this pull request
Jun 22, 2025
* demo-repo/restructure: (31 commits) refactor: restructure into demo folder chore: update to llm-chain 0.22 (#27) refactor: more error handling in vidoe example chore: symfony 7.3 update fix: pin chroma db version and clean up (#26) feat: add demo of GPT vision capabilities based on video stream (#22) chore: dependecy update (#23) feat: extend wikipedia system prompt by tools (#21) chore: update to lib v0.19 (#20) refactor: optimize audio chat ui (#19) feat: audio example (#18) chore: updating dependencies (#17) chore: composer update incl twig cve patch (#16) chore: llm chain update with system_prompt support (#15) chore: install bundle 0.12 (#14) chore: update to llm-chain 0.11.0 (#13) chore: library update (#12) refactor: follow up on example structure to have them cleaner and more separated (#11) fix: typed animation only on xhr responses (#10) refactor: moving classes to a more component like structure (#9) ...
chr-hertel
added a commit
that referenced
this pull request
Jun 22, 2025
* demo-repo/restructure: (31 commits) refactor: restructure into demo folder chore: update to llm-chain 0.22 (#27) refactor: more error handling in vidoe example chore: symfony 7.3 update fix: pin chroma db version and clean up (#26) feat: add demo of GPT vision capabilities based on video stream (#22) chore: dependecy update (#23) feat: extend wikipedia system prompt by tools (#21) chore: update to lib v0.19 (#20) refactor: optimize audio chat ui (#19) feat: audio example (#18) chore: updating dependencies (#17) chore: composer update incl twig cve patch (#16) chore: llm chain update with system_prompt support (#15) chore: install bundle 0.12 (#14) chore: update to llm-chain 0.11.0 (#13) chore: library update (#12) refactor: follow up on example structure to have them cleaner and more separated (#11) fix: typed animation only on xhr responses (#10) refactor: moving classes to a more component like structure (#9) ...
chr-hertel
added a commit
that referenced
this pull request
Jun 23, 2025
* demo-repo/restructure: (31 commits) refactor: restructure into demo folder chore: update to llm-chain 0.22 (#27) refactor: more error handling in vidoe example chore: symfony 7.3 update fix: pin chroma db version and clean up (#26) feat: add demo of GPT vision capabilities based on video stream (#22) chore: dependecy update (#23) feat: extend wikipedia system prompt by tools (#21) chore: update to lib v0.19 (#20) refactor: optimize audio chat ui (#19) feat: audio example (#18) chore: updating dependencies (#17) chore: composer update incl twig cve patch (#16) chore: llm chain update with system_prompt support (#15) chore: install bundle 0.12 (#14) chore: update to llm-chain 0.11.0 (#13) chore: library update (#12) refactor: follow up on example structure to have them cleaner and more separated (#11) fix: typed animation only on xhr responses (#10) refactor: moving classes to a more component like structure (#9) ...
chr-hertel
added a commit
that referenced
this pull request
Jun 23, 2025
* integrate-demo: (31 commits) refactor: restructure into demo folder chore: update to llm-chain 0.22 (#27) refactor: more error handling in vidoe example chore: symfony 7.3 update fix: pin chroma db version and clean up (#26) feat: add demo of GPT vision capabilities based on video stream (#22) chore: dependecy update (#23) feat: extend wikipedia system prompt by tools (#21) chore: update to lib v0.19 (#20) refactor: optimize audio chat ui (#19) feat: audio example (#18) chore: updating dependencies (#17) chore: composer update incl twig cve patch (#16) chore: llm chain update with system_prompt support (#15) chore: install bundle 0.12 (#14) chore: update to llm-chain 0.11.0 (#13) chore: library update (#12) refactor: follow up on example structure to have them cleaner and more separated (#11) fix: typed animation only on xhr responses (#10) refactor: moving classes to a more component like structure (#9) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably controversial, but I suppose we want to follow the same rules as the main Symfony repository.