Skip to content

Commit

Permalink
bug #746 Including alerts.js and changing loading order (ptrm04, Peter)
Browse files Browse the repository at this point in the history
This PR was merged into the master branch.

Discussion
----------

Including alerts.js and changing loading order

Alerts currently can't be dismissed in the symfony-demo app.
Also, updating the loading order to a correct one: https://github.com/twbs/bootstrap-sass#javascript

Commits
-------

5375d40 Adding .fade and .in to use animation when closing
b0ac79c Yarn'd for prod
c39d745 Yarn'd after including alert.js
10a7ba8 Fixing a typo
364c6b0 Including alerts.js and changing loading order
  • Loading branch information
javiereguiluz committed Jan 8, 2018
2 parents c3c3abe + 5375d40 commit 73102db
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
3 changes: 2 additions & 1 deletion assets/js/app.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
// loads the Bootstrap jQuery plugins
import 'bootstrap-sass/assets/javascripts/bootstrap/transition.js';
import 'bootstrap-sass/assets/javascripts/bootstrap/alert.js';
import 'bootstrap-sass/assets/javascripts/bootstrap/collapse.js';
import 'bootstrap-sass/assets/javascripts/bootstrap/dropdown.js';
import 'bootstrap-sass/assets/javascripts/bootstrap/modal.js';
import 'bootstrap-sass/assets/javascripts/bootstrap/transition.js';

// loads the code syntax highlighting library
import './highlight.js';
Loading

0 comments on commit 73102db

Please sign in to comment.