feature #948 #946 use Voter constants instead of plain explicit strin…

…g (inmarelibero)

This PR was squashed before being merged into the master branch (closes #948).

Discussion
----------

#946 use Voter constants instead of plain explicit string

address issue #946

Commits
-------

9ace78f #946 use Voter constants instead of plain explicit string

src/Controller/Admin/BlogController.php

@@ -14,6 +14,7 @@
 use App\Entity\Post;
 use App\Form\PostType;
 use App\Repository\PostRepository;
+use App\Security\PostVoter;
 use App\Utils\Slugger;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\IsGranted;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
@@ -119,7 +120,7 @@ public function show(Post $post): Response
     {
         // This security check can also be performed
         // using an annotation: @IsGranted("show", subject="post", message="Posts can only be shown to their authors.")
-        $this->denyAccessUnlessGranted('show', $post, 'Posts can only be shown to their authors.');
+        $this->denyAccessUnlessGranted(PostVoter::SHOW, $post, 'Posts can only be shown to their authors.');
 
         return $this->render('admin/blog/show.html.twig', [
             'post' => $post,

src/Security/PostVoter.php

@@ -28,9 +28,9 @@ class PostVoter extends Voter
 {
     // Defining these constants is overkill for this simple application, but for real
     // applications, it's a recommended practice to avoid relying on "magic strings"
-    private const SHOW = 'show';
-    private const EDIT = 'edit';
-    private const DELETE = 'delete';
+    public const DELETE = 'delete';
+    public const EDIT = 'edit';
+    public const SHOW = 'show';
 
     /**
      * {@inheritdoc}