minor #823 Use PHP_OS_FAMILY constant thanks to Symfony's PHP 7.2 pol…

…yfill (javiereguiluz) This PR was merged into the master branch. Discussion ---------- Use PHP_OS_FAMILY constant thanks to Symfony's PHP 7.2 polyfill Commits ------- d2f6d14 Use PHP_OS_FAMILY constant thanks to Symfony's PHP 7.2 polyfill
symfony · Jun 28, 2018 · 9998987 · 9998987
2 parents 1e702e5 + d2f6d14
commit 9998987
Show file tree

Hide file tree

Showing 3 changed files with 58 additions and 59 deletions.
diff --git a/composer.json b/composer.json
@@ -19,6 +19,7 @@
         "symfony/form": "^4.1",
         "symfony/framework-bundle": "^4.1",
         "symfony/monolog-bundle": "^3.1",
+        "symfony/polyfill-php72": "^1.8",
         "symfony/security-bundle": "^4.1",
         "symfony/swiftmailer-bundle": "^3.1",
         "symfony/translation": "^4.1",

diff --git a/composer.lock b/composer.lock
diff --git a/tests/Command/AddUserCommandTest.php b/tests/Command/AddUserCommandTest.php
@@ -33,9 +33,7 @@ protected function setUp()
         exec('stty 2>&1', $output, $exitcode);
         $isSttySupported = 0 === $exitcode;
 
-        $isWindows = '\\' === \DIRECTORY_SEPARATOR;
-
-        if ($isWindows || !$isSttySupported) {
+        if ('Windows' === PHP_OS_FAMILY || !$isSttySupported) {
             $this->markTestSkipped('`stty` is required to test this command.');
         }
     }