feature #1406 chore: readonly properties (COil)

This PR was squashed before being merged into the main branch.

Discussion
----------

chore: readonly properties

+ other PHP 8.1 upgrades (rector)

Commits
-------

6a9fc06 chore: readonly properties

src/Command/AddUserCommand.php

@@ -56,10 +56,10 @@ class AddUserCommand extends Command
     private SymfonyStyle $io;
 
     public function __construct(
-        private EntityManagerInterface $entityManager,
-        private UserPasswordHasherInterface $passwordHasher,
-        private Validator $validator,
-        private UserRepository $users
+        private readonly EntityManagerInterface $entityManager,
+        private readonly UserPasswordHasherInterface $passwordHasher,
+        private readonly Validator $validator,
+        private readonly UserRepository $users
     ) {
         parent::__construct();
     }
@@ -124,7 +124,7 @@ protected function interact(InputInterface $input, OutputInterface $output): voi
         if (null !== $username) {
             $this->io->text(' > <info>Username</info>: '.$username);
         } else {
-            $username = $this->io->ask('Username', null, [$this->validator, 'validateUsername']);
+            $username = $this->io->ask('Username', null, $this->validator->validateUsername(...));
             $input->setArgument('username', $username);
         }
 
@@ -135,7 +135,7 @@ protected function interact(InputInterface $input, OutputInterface $output): voi
         if (null !== $password) {
             $this->io->text(' > <info>Password</info>: '.u('*')->repeat(u($password)->length()));
         } else {
-            $password = $this->io->askHidden('Password (your type will be hidden)', [$this->validator, 'validatePassword']);
+            $password = $this->io->askHidden('Password (your type will be hidden)', $this->validator->validatePassword(...));
             $input->setArgument('password', $password);
         }
 
@@ -144,7 +144,7 @@ protected function interact(InputInterface $input, OutputInterface $output): voi
         if (null !== $email) {
             $this->io->text(' > <info>Email</info>: '.$email);
         } else {
-            $email = $this->io->ask('Email', null, [$this->validator, 'validateEmail']);
+            $email = $this->io->ask('Email', null, $this->validator->validateEmail(...));
             $input->setArgument('email', $email);
         }
 
@@ -153,7 +153,7 @@ protected function interact(InputInterface $input, OutputInterface $output): voi
         if (null !== $fullName) {
             $this->io->text(' > <info>Full Name</info>: '.$fullName);
         } else {
-            $fullName = $this->io->ask('Full Name', null, [$this->validator, 'validateFullName']);
+            $fullName = $this->io->ask('Full Name', null, $this->validator->validateFullName(...));
             $input->setArgument('full-name', $fullName);
         }
     }

src/Command/DeleteUserCommand.php

@@ -48,10 +48,10 @@ class DeleteUserCommand extends Command
     private SymfonyStyle $io;
 
     public function __construct(
-        private EntityManagerInterface $entityManager,
-        private Validator $validator,
-        private UserRepository $users,
-        private LoggerInterface $logger
+        private readonly EntityManagerInterface $entityManager,
+        private readonly Validator $validator,
+        private readonly UserRepository $users,
+        private readonly LoggerInterface $logger
     ) {
         parent::__construct();
     }
@@ -101,7 +101,7 @@ protected function interact(InputInterface $input, OutputInterface $output): voi
             '',
         ]);
 
-        $username = $this->io->ask('Username', null, [$this->validator, 'validateUsername']);
+        $username = $this->io->ask('Username', null, $this->validator->validateUsername(...));
         $input->setArgument('username', $username);
     }
 

src/Command/ListUsersCommand.php

@@ -46,9 +46,9 @@
 class ListUsersCommand extends Command
 {
     public function __construct(
-        private MailerInterface $mailer,
-        private string $emailSender,
-        private UserRepository $users
+        private readonly MailerInterface $mailer,
+        private readonly string $emailSender,
+        private readonly UserRepository $users
     ) {
         parent::__construct();
     }

src/DataFixtures/AppFixtures.php

@@ -25,8 +25,8 @@
 class AppFixtures extends Fixture
 {
     public function __construct(
-        private UserPasswordHasherInterface $passwordHasher,
-        private SluggerInterface $slugger
+        private readonly UserPasswordHasherInterface $passwordHasher,
+        private readonly SluggerInterface $slugger
     ) {
     }
 

src/EventSubscriber/CheckRequirementsSubscriber.php

@@ -32,7 +32,7 @@
 class CheckRequirementsSubscriber implements EventSubscriberInterface
 {
     public function __construct(
-        private EntityManagerInterface $entityManager
+        private readonly EntityManagerInterface $entityManager
     ) {
     }
 

src/EventSubscriber/CommentNotificationSubscriber.php

@@ -28,10 +28,10 @@
 class CommentNotificationSubscriber implements EventSubscriberInterface
 {
     public function __construct(
-        private MailerInterface $mailer,
-        private UrlGeneratorInterface $urlGenerator,
-        private TranslatorInterface $translator,
-        private string $sender
+        private readonly MailerInterface $mailer,
+        private readonly UrlGeneratorInterface $urlGenerator,
+        private readonly TranslatorInterface $translator,
+        private readonly string $sender
     ) {
     }
 

src/EventSubscriber/ControllerSubscriber.php

@@ -26,7 +26,7 @@
 class ControllerSubscriber implements EventSubscriberInterface
 {
     public function __construct(
-        private SourceCodeExtension $twigExtension
+        private readonly SourceCodeExtension $twigExtension
     ) {
     }
 

src/EventSubscriber/RedirectToPreferredLocaleSubscriber.php

@@ -32,10 +32,10 @@ class RedirectToPreferredLocaleSubscriber implements EventSubscriberInterface
      * @var string[]
      */
     private array $locales;
-    private string $defaultLocale;
+    private readonly string $defaultLocale;
 
     public function __construct(
-        private UrlGeneratorInterface $urlGenerator,
+        private readonly UrlGeneratorInterface $urlGenerator,
         string $locales,
         ?string $defaultLocale = null
     ) {

src/Form/DataTransformer/TagArrayToStringTransformer.php

@@ -30,7 +30,7 @@
 class TagArrayToStringTransformer implements DataTransformerInterface
 {
     public function __construct(
-        private TagRepository $tags
+        private readonly TagRepository $tags
     ) {
     }
 

src/Form/PostType.php

@@ -33,7 +33,7 @@ class PostType extends AbstractType
 {
     // Form types are services, so you can inject other services in them if needed
     public function __construct(
-        private SluggerInterface $slugger
+        private readonly SluggerInterface $slugger
     ) {
     }
 

src/Form/Type/DateTimePickerType.php

@@ -30,7 +30,7 @@
 class DateTimePickerType extends AbstractType
 {
     public function __construct(
-        private MomentFormatConverter $formatConverter
+        private readonly MomentFormatConverter $formatConverter
     ) {
     }
 

src/Form/Type/TagsInputType.php

@@ -31,7 +31,7 @@
 class TagsInputType extends AbstractType
 {
     public function __construct(
-        private TagRepository $tags
+        private readonly TagRepository $tags
     ) {
     }
 

src/Pagination/Paginator.php

@@ -26,7 +26,7 @@ class Paginator
      *
      * See https://symfony.com/doc/current/best_practices.html#use-constants-to-define-options-that-rarely-change
      */
-    public const PAGE_SIZE = 10;
+    final public const PAGE_SIZE = 10;
 
     private int $currentPage;
     private int $numResults;
@@ -37,8 +37,8 @@ class Paginator
     private \Traversable $results;
 
     public function __construct(
-        private DoctrineQueryBuilder $queryBuilder,
-        private int $pageSize = self::PAGE_SIZE
+        private readonly DoctrineQueryBuilder $queryBuilder,
+        private readonly int $pageSize = self::PAGE_SIZE
     ) {
     }
 

src/Twig/AppExtension.php

@@ -27,7 +27,7 @@ class AppExtension extends AbstractExtension
     /**
      * @var string[]
      */
-    private array $localeCodes;
+    private readonly array $localeCodes;
 
     /**
      * @var list<array{code: string, name: string}>|null
@@ -46,7 +46,7 @@ public function __construct(string $locales)
     public function getFunctions(): array
     {
         return [
-            new TwigFunction('locales', [$this, 'getLocales']),
+            new TwigFunction('locales', $this->getLocales(...)),
         ];
     }