Remove Sass from custom CSS files #1450
Conversation
| @@ -50,18 +50,45 @@ | |||
| @include lato-include-font('normal'); | |||
| @include lato-include-font('bold'); | |||
|
|
|||
| :root { | |||
| --font-heading: 2.5rem; | |||
There was a problem hiding this comment.
I would call these --font-size-heading and so on. font-heading makes me think this is expected to define the font used in headings.
There was a problem hiding this comment.
I agree with you. The name is "bad". But I kept it to use the exact same name as the Sass version, to ease the upgrade 🙏
There was a problem hiding this comment.
I've merged this with the bad variable names ... when the whole upgrade to AssetMapper is finished, we can rename and reorganize these properties. Thanks!
|
Oh, this would make life MUCH easier over on my PR - thank you! After this, on that PR, we could focus on: A) importing CSS versions (instead of sass) for all of the vendor packages other than Bootstrap ( |
javiereguiluz
force-pushed
the
remove_sass
branch
from
e058dc4
to
691859e
Compare
This PR was squashed before being merged into the main branch. Discussion ---------- [WIP] Upgrading to AssetMapper 6.4 Hi! This converts from Encore to AssetMapper 6.4 (and also upgrading to Symfony 6.4 in general). This was the final product of a live stream walking through this process - https://www.youtube.com/watch?v=pyj1hvhcxGc There are still some TODOs to finish. The biggest is the first, as Sass is quite embedded in there. - [X] ~~A) convert Sass->CSS (not a requirement for AssetMapper, but Javier & I talked about this). Then remove SassBundle & bootstrap in `composer.json`. Probably many Sass variables should be converted to CSS variables. See #1450 and #1452~~. Much of this was done, Sass kept just for Bootstrap. - [X] ~~B) In `assets/app.js`, I should just be able to import from the individual `bootstrap` package instead of requiring each part~~ It's fine how it is. When we upgrade, perhaps we could look at it then. - [X] C) commit `public/assets/` or `assets/vendor/` so the code works after clone with ZERO other commands. Else, the user will need to run `importmap:install`. - [x] D) update `devcontainer.json` - [x] E) fix the `admin` entrypoint & layout It's a busy month! If anyone is interested in trying to fix any of the above points, just let me know here or on Slack. I'd be more than happy to coach someone through them. Cheers! Commits ------- 634f238 [WIP] Upgrading to AssetMapper 6.4
This is mentioned by @weaverryan in #1449.
We don't really use any Sass feature (except nesting and some variables). I've replaced Sass variables by CSS custom properties ... and removed the nesting by flattening all styles (we can readd nesting soon when native support is a big bigger than today: https://caniuse.com/?search=nesting).
Ryan, if you agree on this, can we just merge it and then you rebase your PR? Thanks!