New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jQuery instantSearch plugin and search result #632

Closed

yceruto wants to merge 2 commits into symfony:master from yceruto:search

Member

yceruto commented Aug 31, 2017 •

edited

Loading

instantSearch

Refactored to some known JavaScript pattern (implemented Prototype Design Pattern)
Allow override options through input attributes data-* and added support to text translation ("No results found")
Add article template prototype and render method (improved visibility)
Sent configured limit of items to search controller (this allows to configure more than 10 items as results from plugin)
Simplify properties and methods (improved visibility)

Search result

Removed old effect of hide/show results on focus out/in of the input
Show publishedDate and author for each article found
Sync style with blog index page and some margin adjustments

Minor unrelated changes

Fix @return type-hints for PostRepository::findBySearchQuery() method (better IDE autocomplete)
Show logout link as last link always

yceruto added 2 commits

August 31, 2017 00:50


          Fix jQuery instantSearch plugin and search result


          Update prod assets

17c0848

javiereguiluz added Feature FINISHED labels

Member

javiereguiluz commented Aug 31, 2017

What can I say? This is fantastic and amazing. I tested it and I love all the changes. Thanks!

javiereguiluz closed this in

2fbc7f7

yceruto deleted the search branch

August 31, 2017 12:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature FINISHED