Added more great Symfony 4.1 features #817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jun 20, 2018
| @@ -39,7 +39,7 @@ class BlogController extends AbstractController | |||
| /** | |||
| * @Route("/", defaults={"page": "1", "_format"="html"}, methods={"GET"}, name="blog_index") | |||
| * @Route("/rss.xml", defaults={"page": "1", "_format"="xml"}, methods={"GET"}, name="blog_rss") | |||
| * @Route("/page/{page}", defaults={"_format"="html"}, requirements={"page": "[1-9]\d*"}, methods={"GET"}, name="blog_index_paginated") | |||
| * @Route("/page/{page<[1-9]\d*>}", defaults={"_format"="html"}, methods={"GET"}, name="blog_index_paginated") | |||
There was a problem hiding this comment.
I would even change it to \d*+. Using possessive quantifiers in routing requirements makes matching faster
| @@ -130,7 +130,7 @@ public function show(Post $post): Response | |||
| /** | |||
| * Displays a form to edit an existing Post entity. | |||
| * | |||
| * @Route("/{id}/edit", requirements={"id": "\d+"}, methods={"GET", "POST"}, name="admin_post_edit") | |||
| * @Route("/{id<\d+>}/edit",methods={"GET", "POST"}, name="admin_post_edit") | |||
There was a problem hiding this comment.
I suggest using a possessive quantifier here (\d++), to improve the route matching performance (Symfony generates possessive quantifiers for its builtin requirements, but custom ones need to do that themselves, as using non-possessive quantifiers can still be a valid use case)
src/Entity/User.php
Outdated
| */ | ||
| private $fullName; | ||
|
|
||
| /** | ||
| * @var string | ||
| * | ||
| * @ORM\Column(type="string", unique=true) | ||
| * @Assert\NotBlank() | ||
| * @Assert\Length(min = 2, max = 50) |
There was a problem hiding this comment.
The existing annotations are not putting spaces around the =
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last remaining big features are: