-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Updated the front-end dependencies #990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We also need to run |
I did that ... don't you see a lot of CSS and JS files here? https://github.com/symfony/demo/pull/990/files I see 38 files created/deleted. |
Victor, please run these commands locally and check if you see anything different. Thanks! $ git checkout master && git fetch upstream && git merge upstream/master && yarn install && yarn encore production
Already on 'master'
Your branch is up to date with 'upstream/master'.
Already up to date.
yarn install v1.16.0
[1/4] 🔍 Resolving packages...
success Already up-to-date.
✨ Done in 0.87s.
yarn run v1.16.0
$ /Users/javier/work/symfony-demo/node_modules/.bin/encore production
Running webpack ...
DONE Compiled successfully in 6354ms 5:15:36 PM
I 38 files written to public/build
Entrypoint app [big] = runtime.26bd8744.js 0.2375624d.js 1.734a5257.js app.9f402dd6.css app.94e6145a.js
Entrypoint login = runtime.26bd8744.js 0.2375624d.js login.897801f7.js
Entrypoint admin [big] = runtime.26bd8744.js 0.2375624d.js 2.665337b4.js admin.5cc2ebf1.css admin.74750e33.js
Entrypoint search = runtime.26bd8744.js 0.2375624d.js 1.734a5257.js search.b34d41ab.js
✨ Done in 8.17s. $ git status
On branch master
Your branch is up to date with 'upstream/master'.
nothing to commit, working tree clean |
@javiereguiluz Hm, yes, I do! Here's my output:
But I used UPD: |
This PR was merged into the master branch. Discussion ---------- Rebuild assets Somehow running `yarn build` on TravisCI sets the repo in a dirty state: https://travis-ci.org/symfony/demo/builds/541616536 Actually, the same for me when I run `yarn build` locally. I rebuilt the assets - let's check if tests pass now. P.S. Basically, continue #990 (comment) Commits ------- 312baf4 Rebuild assets
This PR was merged into the master branch. Discussion ---------- Rebuild assets Somehow running `yarn build` on TravisCI sets the repo in a dirty state: https://travis-ci.org/symfony/demo/builds/541616536 Actually, the same for me when I run `yarn build` locally. I rebuilt the assets - let's check if tests pass now. P.S. Basically, continue symfony/demo#990 (comment) Commits ------- 312baf4 Rebuild assets
This PR was merged into the master branch. Discussion ---------- Rebuild assets Somehow running `yarn build` on TravisCI sets the repo in a dirty state: https://travis-ci.org/symfony/demo/builds/541616536 Actually, the same for me when I run `yarn build` locally. I rebuilt the assets - let's check if tests pass now. P.S. Basically, continue symfony/demo#990 (comment) Commits ------- 312baf4 Rebuild assets
This PR was merged into the master branch. Discussion ---------- Rebuild assets Somehow running `yarn build` on TravisCI sets the repo in a dirty state: https://travis-ci.org/symfony/demo/builds/541616536 Actually, the same for me when I run `yarn build` locally. I rebuilt the assets - let's check if tests pass now. P.S. Basically, continue symfony/demo#990 (comment) Commits ------- 312baf4 Rebuild assets
No description provided.