Skip to content

Updated the front-end dependencies #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Updated the front-end dependencies #990

wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

No description provided.

@bocharsky-bw
Copy link
Contributor

We also need to run yarn install && yarn build and commit changes here

@javiereguiluz
Copy link
Member Author

I did that ... don't you see a lot of CSS and JS files here? https://github.com/symfony/demo/pull/990/files I see 38 files created/deleted.

@bocharsky-bw
Copy link
Contributor

I still see uncommitted changes locally after running yarn build:

Screen Shot 2019-06-03 at 18 05 18

@javiereguiluz
Copy link
Member Author

Victor, please run these commands locally and check if you see anything different. Thanks!

$ git checkout master && git fetch upstream && git merge upstream/master && yarn install && yarn encore production

Already on 'master'
Your branch is up to date with 'upstream/master'.
Already up to date.
yarn install v1.16.0
[1/4] 🔍  Resolving packages...
success Already up-to-date.
✨  Done in 0.87s.
yarn run v1.16.0
$ /Users/javier/work/symfony-demo/node_modules/.bin/encore production
Running webpack ...

 DONE  Compiled successfully in 6354ms                                                                                                                                                              5:15:36 PM

 I  38 files written to public/build
Entrypoint app [big] = runtime.26bd8744.js 0.2375624d.js 1.734a5257.js app.9f402dd6.css app.94e6145a.js
Entrypoint login = runtime.26bd8744.js 0.2375624d.js login.897801f7.js
Entrypoint admin [big] = runtime.26bd8744.js 0.2375624d.js 2.665337b4.js admin.5cc2ebf1.css admin.74750e33.js
Entrypoint search = runtime.26bd8744.js 0.2375624d.js 1.734a5257.js search.b34d41ab.js
✨  Done in 8.17s.
$ git status

On branch master
Your branch is up to date with 'upstream/master'.

nothing to commit, working tree clean

@bocharsky-bw
Copy link
Contributor

bocharsky-bw commented Jun 3, 2019

@javiereguiluz Hm, yes, I do! Here's my output:

$ git checkout master && git fetch origin  && git merge origin/master && yarn install && yarn encore production
$ git status

On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	deleted:    public/build/2.665337b4.js
	modified:   public/build/entrypoints.json
	modified:   public/build/manifest.json

Untracked files:
  (use "git add <file>..." to include in what will be committed)

	public/build/2.63838593.js

no changes added to commit (use "git add" and/or "git commit -a")

But I used origin instead, I don't have upstream.

UPD:
yarn --version # 1.15.2
npm --version # 6.7.0

@bocharsky-bw bocharsky-bw mentioned this pull request Jun 6, 2019
javiereguiluz added a commit that referenced this pull request Jun 7, 2019
This PR was merged into the master branch.

Discussion
----------

Rebuild assets

Somehow running `yarn build` on TravisCI  sets the repo in a dirty state:
https://travis-ci.org/symfony/demo/builds/541616536

Actually, the same for me when I run `yarn build` locally. I rebuilt the assets - let's check if tests pass now.

P.S. Basically, continue #990 (comment)

Commits
-------

312baf4 Rebuild assets
sayjun0505 added a commit to sayjun0505/sym_proj that referenced this pull request Apr 16, 2023
This PR was merged into the master branch.

Discussion
----------

Rebuild assets

Somehow running `yarn build` on TravisCI  sets the repo in a dirty state:
https://travis-ci.org/symfony/demo/builds/541616536

Actually, the same for me when I run `yarn build` locally. I rebuilt the assets - let's check if tests pass now.

P.S. Basically, continue symfony/demo#990 (comment)

Commits
-------

312baf4 Rebuild assets
spider-yamet added a commit to spider-yamet/sym_proj that referenced this pull request Apr 16, 2023
This PR was merged into the master branch.

Discussion
----------

Rebuild assets

Somehow running `yarn build` on TravisCI  sets the repo in a dirty state:
https://travis-ci.org/symfony/demo/builds/541616536

Actually, the same for me when I run `yarn build` locally. I rebuilt the assets - let's check if tests pass now.

P.S. Basically, continue symfony/demo#990 (comment)

Commits
-------

312baf4 Rebuild assets
frederickboyd added a commit to frederickboyd/frederickboyd that referenced this pull request May 25, 2025
This PR was merged into the master branch.

Discussion
----------

Rebuild assets

Somehow running `yarn build` on TravisCI  sets the repo in a dirty state:
https://travis-ci.org/symfony/demo/builds/541616536

Actually, the same for me when I run `yarn build` locally. I rebuilt the assets - let's check if tests pass now.

P.S. Basically, continue symfony/demo#990 (comment)

Commits
-------

312baf4 Rebuild assets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants