[DomCrawler] Add argument $default to Crawler::attr()

symfony · Aug 17, 2023 · 043715b · 043715b
1 parent 8342592
commit 043715b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@ CHANGELOG
 ---
 
  * Add argument `$normalizeWhitespace` to `Crawler::innerText()`
+ * Add argument `$default` to `Crawler::attr()`
 
 6.4
 ---

diff --git a/Crawler.php b/Crawler.php
@@ -504,9 +504,8 @@ public function children(string $selector = null): static
      *
      * @throws \InvalidArgumentException When current node is empty
      */
-    public function attr(string $attribute/* , string $default = null */): ?string
+    public function attr(string $attribute, string $default = null): ?string
     {
-        $default = \func_num_args() > 1 ? func_get_arg(1) : null;
         if (!$this->nodes) {
             if (null !== $default) {
                 return $default;
-Original file line number
+Diff line change
@@ Expand Up / @@ -5,6 +5,7 @@ CHANGELOG @@
     ---
      * Add argument `$normalizeWhitespace` to `Crawler::innerText()`
+     * Add argument `$default` to `Crawler::attr()`
 .4
     ---
@@ Expand Down @@