fix(recipes:update): github api now requires is:pull-request parameter #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhelias
approved these changes
Dec 5, 2023
xabbuh
approved these changes
Dec 5, 2023
fabpot
requested changes
Dec 5, 2023
src/GithubApi.php
Outdated
| @@ -142,7 +142,7 @@ public function getPullRequestForCommit(string $commit, string $repo): ?array | |||
| $bestItem = null; | |||
| foreach ($data['items'] as $item) { | |||
| // make sure the PR referenced isn't from a different repository | |||
| if (false === strpos($item['html_url'], sprintf('%s/pull', $repositoryName))) { | |||
| if (!str_contains($item['html_url'], sprintf('%s/pull', $repositoryName))) { | |||
There was a problem hiding this comment.
Can you revert the 2 unrelated changes?
There was a problem hiding this comment.
I did. Had to commit this code to make fabbot.io happy in the first place.
fabpot
force-pushed
the
issue-974-github-api-now-requires-is-pullrequest-param
branch
from
a5c33dd
to
bc89553
Compare
|
Thank you @alainsharemat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is related to issue #974.
While running
recipes:updateI got this error:According to github's documentation :
Requests that don't include the is:issue or is:pull-request qualifier will receive an HTTP 422 Unprocessable Entity response.