Add SYMFONY_REQUIRE env var + disable recipes when flex is not in the root composer.json #409

nicolas-grekas · 2018-08-13T17:41:55Z

The C.I. for symfony/symfony is starting to fail transiently because solving the dependency graph takes too much memory.
See e.g. https://ci.appveyor.com/project/fabpot/symfony/build/1.0.39377

But thanks to recent improvements in Flex, we know why and how to fix that: skipping old tags.
This PR allows using Flex while disabling the recipes subsystem and allows configuring the minimum version of components we give to the solver.

I plan to use the next version of Flex that embeds this PR (could be v1.1.0 btw) on symfony/symfony.

nicolas-grekas · 2018-08-13T17:45:28Z

For symfony/symfony master:

before:
Memory usage: (peak: 1065.49MB), time: 9.91s

with SYMFONY_REQUIRE='~4.1':
Memory usage: (peak: 257.37MB), time: 2.57s

nicolas-grekas · 2018-08-14T08:26:11Z

PR now handles a new SYMFONY_REQUIRE env var that should contain a version constraint that will apply to all packages replaced by symfony/symfony.
This works without having to explicitly list these packages in the source, easing maintenance.

This will also allow deprecating symfony/lts and symfony/force-lowest, allowing to simplify the releasing process: libs that currently use them to test several versions of Symfony components could composer global require symfony/flex + e.g. SYMFONY_REQUIRE='4.1.*'

BoShurik · 2018-08-14T08:36:56Z

@nicolas-grekas is it possible to set extra.symfony.require instead of SYMFONY_REQUIRE env var?

nicolas-grekas · 2018-08-14T08:39:31Z

@BoShurik I forgot to mention it, but Yes! I even plan to use it in our skeletons to replace symfony/lts.

nicolas-grekas · 2018-08-14T11:28:45Z

PR ready, works as expected in symfony/symfony#28199

nicolas-grekas · 2018-08-18T07:48:01Z

Now with a notice:

PR ready, it works well :)

nicolas-grekas · 2018-08-18T07:49:08Z

src/Downloader.php

        $this->io = $io;
        $config = $composer->getConfig();
        $this->rfs = $rfs;
        $this->cache = new ComposerCache($io, $config->get('cache-repo-dir').'/'.preg_replace('{[^a-z0-9.]}i', '-', $this->endpoint));
        $this->sess = bin2hex(random_bytes(16));
-
-        if (self::$DEFAULT_ENDPOINT !== $endpoint) {
-            $this->io->writeError('<warning>Warning: Using '.$endpoint.' as the Symfony endpoint</warning>');


warning moved below, so that unrelated Composer commands don't display it.

nicolas-grekas · 2018-08-18T08:57:17Z

I removed the special handling of the "none" endpoint. Instead, flex disables recipes (displaying a warning) when it can't find itself in the "require" of the root composer.json

fabpot · 2018-08-18T15:30:39Z

src/Downloader.php

+                'manifests' => [],
+                'vulnerabilities' => [],
+                'locks' => [],
+            ];


I don"t think this is needed and should probably be removed.

L135 populates $bodies with empty arrays, that's why.

Pfff but the "if" L135 also prevents it...

But this code works right now without adding this, right?

… root composer.json

fabpot · 2018-08-18T15:51:49Z

Thank you @nicolas-grekas.

…is not in the root composer.json (nicolas-grekas) This PR was squashed before being merged into the 1.0-dev branch (closes #409). Discussion ---------- Add SYMFONY_REQUIRE env var + disable recipes when flex is not in the root composer.json The C.I. for `symfony/symfony` is starting to fail transiently because solving the dependency graph takes too much memory. See e.g. https://ci.appveyor.com/project/fabpot/symfony/build/1.0.39377 But thanks to recent improvements in Flex, we know why and how to fix that: skipping old tags. This PR allows using Flex while disabling the recipes subsystem and allows configuring the minimum version of components we give to the solver. I plan to use the next version of Flex that embeds this PR (could be v1.1.0 btw) on `symfony/symfony`. Commits ------- 8649abc Add SYMFONY_REQUIRE env var + disable recipes when flex is not in the root composer.json

… (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [travis][appveyor] use symfony/flex to accelerate builds | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Playing with symfony/flex#409 The optimization is required because appveyor is transiently failing with OOM errors, see e.g. https://ci.appveyor.com/project/fabpot/symfony/build/1.0.39377 Commits ------- 940ec8f [travis][appveyor] use symfony/flex to accelerate builds

… (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- Use extra.symfony.require to restrict versions of symfony/* Proposed way to leverage symfony/flex#409 Benefits: - no `symfony/lts` / `symfony/force-lowest` anymore - only one line to change to upgrade to next minor - better control of exact minor used (right now, skeleton:4.0 pulls 4.1 components) - (and a lot less merge conflicts for us when merging 3.4 up to master); Commits ------- 32dec7e Use extra.symfony.require to restrict versions of symfony/*

… (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- Use extra.symfony.require to restrict versions of symfony/* Same as symfony/skeleton#93 on website-skeleton. See symfony/flex#409 Commits ------- b899463 Use extra.symfony.require to restrict versions of symfony/*

See symfony/flex#409

nicolas-grekas changed the title ~~Add SYMFONY_LOWEST_VERSION env var + handle SYMFONY_ENDPOINT=none~~ Add SYMFONY_REQUIRE env var + handle SYMFONY_ENDPOINT=none Aug 14, 2018

nicolas-grekas mentioned this pull request Aug 14, 2018

[travis][appveyor] use symfony/flex to accelerate builds symfony/symfony#28199

Merged

symfony deleted a comment from maxhelias Aug 14, 2018

nicolas-grekas commented Aug 18, 2018

View reviewed changes

nicolas-grekas changed the title ~~Add SYMFONY_REQUIRE env var + handle SYMFONY_ENDPOINT=none~~ Add SYMFONY_REQUIRE env var + + disable recipes when flex is not in the root composer.json Aug 18, 2018

nicolas-grekas changed the title ~~Add SYMFONY_REQUIRE env var + + disable recipes when flex is not in the root composer.json~~ Add SYMFONY_REQUIRE env var + disable recipes when flex is not in the root composer.json Aug 18, 2018

fabpot reviewed Aug 18, 2018

View reviewed changes

Add SYMFONY_REQUIRE env var + disable recipes when flex is not in the…

8649abc

… root composer.json

fabpot merged commit 8649abc into symfony:master Aug 18, 2018

nicolas-grekas deleted the flex-env-config branch August 18, 2018 20:17

rubenrua mentioned this pull request Aug 21, 2018

Add extra.symfony.require into composer core. composer/composer#7577

Closed

jlekowski mentioned this pull request Aug 23, 2018

Symfony recipes are disabled when flex set as dev dependency #414

Closed

nicolas-grekas mentioned this pull request Aug 24, 2018

Abandon package dunglas/symfony-lock#5

Open

nicolas-grekas mentioned this pull request Nov 7, 2018

Unbounded constraints impact memory usage / execution time #432

Closed

mnocon mentioned this pull request Jun 27, 2019

[Composer] Use extra.symfony.require to restrict versions of symfony/* ezsystems/ezplatform#422

Closed

Tetragramat mentioned this pull request Feb 4, 2020

Added symfony 5 into travis Payum/PayumBundle#504

Merged

Tobion mentioned this pull request Feb 5, 2020

improve composer.json and travis tests BedrockStreaming/AmqpBundle#57

Merged

Kocal added a commit to Yproximite/influxdb-preset-bundle that referenced this pull request Jun 22, 2020

fix(ci): dont install symfony flex in project, use SYMFONY_REQUIRE

f7b76e7

See symfony/flex#409

tristanbes mentioned this pull request Jun 22, 2020

A lot of fixes and dependencies update Yproximite/influxdb-preset-bundle#6

Merged

Kocal added a commit to Yproximite/influxdb-bundle that referenced this pull request Oct 29, 2020

chore(ci): use Symfony Flex and SYMFONY_VERSION, see symfony/flex#409

68c7654

Kocal mentioned this pull request Oct 29, 2020

chore(ci): Make the CI happy Algatux/influxdb-bundle#95

Closed

Kocal added a commit to Yproximite/influxdb-bundle that referenced this pull request Oct 29, 2020

chore(ci): use Symfony Flex and SYMFONY_VERSION, see symfony/flex#409

f8746d1

Kocal added a commit to Yproximite/influxdb-bundle that referenced this pull request Oct 29, 2020

chore(ci): use Symfony Flex and SYMFONY_REQUIRE, see symfony/flex#409

9ab963d

tgalopin pushed a commit to tgalopin/flex that referenced this pull request Dec 3, 2020

Merge pull request symfony#409

f480647

spideyfusion mentioned this pull request Jan 14, 2022

Make Dependabot respect Symfony Flex's "extra.symfony.require" setting dependabot/dependabot-core#4631

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add SYMFONY_REQUIRE env var + disable recipes when flex is not in the root composer.json #409

Add SYMFONY_REQUIRE env var + disable recipes when flex is not in the root composer.json #409

nicolas-grekas commented Aug 13, 2018

nicolas-grekas commented Aug 13, 2018 •

edited

Loading

nicolas-grekas commented Aug 14, 2018 •

edited

Loading

BoShurik commented Aug 14, 2018

nicolas-grekas commented Aug 14, 2018

nicolas-grekas commented Aug 14, 2018

nicolas-grekas commented Aug 18, 2018

nicolas-grekas Aug 18, 2018 •

edited

Loading

nicolas-grekas commented Aug 18, 2018 •

edited

Loading

fabpot Aug 18, 2018

nicolas-grekas Aug 18, 2018

nicolas-grekas Aug 18, 2018

fabpot Aug 18, 2018

nicolas-grekas Aug 18, 2018

fabpot commented Aug 18, 2018

Add SYMFONY_REQUIRE env var + disable recipes when flex is not in the root composer.json #409

Add SYMFONY_REQUIRE env var + disable recipes when flex is not in the root composer.json #409

Conversation

nicolas-grekas commented Aug 13, 2018

nicolas-grekas commented Aug 13, 2018 • edited Loading

nicolas-grekas commented Aug 14, 2018 • edited Loading

BoShurik commented Aug 14, 2018

nicolas-grekas commented Aug 14, 2018

nicolas-grekas commented Aug 14, 2018

nicolas-grekas commented Aug 18, 2018

nicolas-grekas Aug 18, 2018 • edited Loading

Choose a reason for hiding this comment

nicolas-grekas commented Aug 18, 2018 • edited Loading

fabpot Aug 18, 2018

Choose a reason for hiding this comment

nicolas-grekas Aug 18, 2018

Choose a reason for hiding this comment

nicolas-grekas Aug 18, 2018

Choose a reason for hiding this comment

fabpot Aug 18, 2018

Choose a reason for hiding this comment

nicolas-grekas Aug 18, 2018

Choose a reason for hiding this comment

fabpot commented Aug 18, 2018

nicolas-grekas commented Aug 13, 2018 •

edited

Loading

nicolas-grekas commented Aug 14, 2018 •

edited

Loading

nicolas-grekas Aug 18, 2018 •

edited

Loading

nicolas-grekas commented Aug 18, 2018 •

edited

Loading