Bump flex to v2, composer >= 2.1, php >= 8.0 #833
Conversation
nicolas-grekas
force-pushed
the
v2
branch
6 times, most recently
from
ed0d0cb to
783961b
Compare
|
Except for "remove legacy code", is there reason to release a new major version? |
|
Should the branch be called |
|
Since Symfony 6 is already requiring composer >= 2.1, I think it's just the right timing to fade out this legacy code yes. Eg I don't want to maintain the CurlDownloader anylonger, and keeping it alive in maintained version is a 💣 waiting to explode on my free time :) The earlier the better. |
then we'd drop |
That's what I was thinking. The |
|
|
|
How long do you think the branch 1.x should be supported? PHP 7.4 EOL is in 1 year, and Symfony 5.4 EOL (with PHP 7.2 support) is in 4 years. If we want to push adoption in order to not maintain legacy code, I think PHP requirements should stay to 7.4 max for now. PHP 8 has several breaking changes that make some projects hard to update. |
| if ($populateRepoCacheDir && isset(self::$repoReadingCommands[$command]) && ('install' !== $command || (file_exists($composerFile = Factory::getComposerFile()) && !file_exists(substr($composerFile, 0, -4).'lock')))) { | ||
| $this->populateRepoCacheDir(); | ||
| } | ||
|
|
||
| $app->add(new Command\RequireCommand($resolver, \Closure::fromCallable([$this, 'updateComposerLock']))); | ||
| $app->add(new Command\UpdateCommand($resolver)); |
There was a problem hiding this comment.
Should those registration be changed to use the CommandProvider of the Composer 1.1+ plugin API instead of relying on the backtrace hack to access the Application ?
There was a problem hiding this comment.
I just had a look and I think there are little benefits in doing so. Limiting merge conflicts with 1.x looks more important to me right now.
With 5.4 the latest, earlier if possible. Stats might help decide.
Symfony 6 is already for PHP8, there is no point in having flex use different versions than both 5.4 and 6.0 to me. |
nicolas-grekas
force-pushed
the
v2
branch
5 times, most recently
from
91aede2 to
7464e65
Compare
Let's drop the legacy since Symfony 6.0 will require composer >= 2.1 anyway.